Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added union on ModelConfig and dict in create_model #3333

Merged
merged 1 commit into from
Apr 8, 2023
Merged

Added union on ModelConfig and dict in create_model #3333

merged 1 commit into from
Apr 8, 2023

Conversation

aseemk98
Copy link
Contributor

@aseemk98 aseemk98 commented Apr 7, 2023

Code Pull Requests

This PR is in reference to #2859 (#2859)
I've added a Union in the static function create_model for the config_obj

@aseemk98 aseemk98 mentioned this pull request Apr 7, 2023
Closed
@arnavgarg1
Copy link
Contributor

PR looks good! Let's wait for tests to run and then I can merge. Thanks for your contribution!

@github-actions
Copy link

github-actions bot commented Apr 8, 2023

Unit Test Results

  4 files  +  1    4 suites  +1   37m 52s ⏱️ + 13m 31s
33 tests ±  0  27 ✔️  -   3    6 💤 +3  0 ❌ ±0 
66 runs  +21  54 ✔️ +14  12 💤 +7  0 ❌ ±0 

Results for commit bd64003. ± Comparison against base commit 46d08c7.

This pull request skips 3 tests. 
tests.regression_tests.benchmark.test_model_performance ‑ test_performance[ames_housing.ecd.yaml]
tests.regression_tests.benchmark.test_model_performance ‑ test_performance[ames_housing.gbm.yaml]
tests.regression_tests.benchmark.test_model_performance ‑ test_performance[mercedes_benz_greener.gbm.yaml]

tgaddair
tgaddair approved these changes Apr 8, 2023
View reviewed changes
Copy link
Collaborator

@tgaddair tgaddair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the PR!

@tgaddair tgaddair linked an issue Apr 8, 2023 that may be closed by this pull request
LudwigModel create_model static method requires a config_obj, but it should take a dict or config obj #2859
Closed
@tgaddair tgaddair merged commit f506ebc into ludwig-ai:master Apr 8, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgaddair tgaddair tgaddair approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LudwigModel create_model static method requires a config_obj, but it should take a dict or config obj
3 participants
@aseemk98 @arnavgarg1 @tgaddair