Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added distinct decoder registries by model type #3342

Merged
merged 7 commits into from
Apr 14, 2023
Merged

Conversation

tgaddair
Copy link
Collaborator

No description provided.

Copy link
Contributor

@arnavgarg1 arnavgarg1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for putting this together so quickly 🔥
Only one minor nit

@github-actions
Copy link

Unit Test Results

       6 files  ±       0         6 suites  ±0   5h 2m 0s ⏱️ + 3h 0m 51s
2 700 tests +2 510  2 663 ✔️ +2 503  35 💤 +  6  2 +1 
2 986 runs  +2 764  2 918 ✔️ +2 733  65 💤 +30  3 +1 

For more details on these failures, see this check.

Results for commit 4a7513d. ± Comparison against base commit b9345ce.

This pull request removes 35 and adds 2545 tests. Note that renamed tests count towards both.
tests.integration_tests.test_cli ‑ test_reproducible_cli_runs[horovod-experiment-1919-0]
tests.integration_tests.test_cli ‑ test_reproducible_cli_runs[horovod-experiment-1919-1]
tests.integration_tests.test_cli ‑ test_reproducible_cli_runs[horovod-experiment-31-0]
tests.integration_tests.test_cli ‑ test_reproducible_cli_runs[horovod-experiment-31-1]
tests.integration_tests.test_cli ‑ test_reproducible_cli_runs[horovod-train-1919-0]
tests.integration_tests.test_cli ‑ test_reproducible_cli_runs[horovod-train-1919-1]
tests.integration_tests.test_cli ‑ test_reproducible_cli_runs[horovod-train-31-0]
tests.integration_tests.test_cli ‑ test_reproducible_cli_runs[horovod-train-31-1]
tests.integration_tests.test_cli ‑ test_train_cli_horovod
tests.integration_tests.test_experiment ‑ test_experiment_model_resume_distributed[horovod]
…
tests.ludwig.augmentation.test_augmentation_pipeline ‑ test_image_augmentation[augmentation_pipeline_ops0]
tests.ludwig.augmentation.test_augmentation_pipeline ‑ test_image_augmentation[augmentation_pipeline_ops1]
tests.ludwig.augmentation.test_augmentation_pipeline ‑ test_image_augmentation[augmentation_pipeline_ops2]
tests.ludwig.augmentation.test_augmentation_pipeline ‑ test_invalid_augmentation_parameters[None]
tests.ludwig.augmentation.test_augmentation_pipeline ‑ test_invalid_augmentation_parameters[augmentation_pipeline_ops1]
tests.ludwig.augmentation.test_augmentation_pipeline ‑ test_invalid_augmentation_parameters[augmentation_pipeline_ops2]
tests.ludwig.augmentation.test_augmentation_pipeline ‑ test_invalid_augmentation_parameters[augmentation_pipeline_ops4]
tests.ludwig.augmentation.test_augmentation_pipeline ‑ test_invalid_augmentation_parameters[random_horizontal_flip]
tests.ludwig.augmentation.test_augmentation_pipeline ‑ test_load_model_with_augmentation_pipeline
tests.ludwig.augmentation.test_augmentation_pipeline ‑ test_local_model_training_with_augmentation_pipeline[preprocessing0-encoder0-False]
…
This pull request removes 13 skipped tests and adds 19 skipped tests. Note that renamed tests count towards both.
tests.integration_tests.test_horovod ‑ test_horovod_gpu_memory_limit
tests.integration_tests.test_torchscript ‑ test_torchscript_postproc_gpu[binary_feature]
tests.integration_tests.test_torchscript ‑ test_torchscript_postproc_gpu[category_feature]
tests.integration_tests.test_torchscript ‑ test_torchscript_postproc_gpu[number_feature]
tests.integration_tests.test_torchscript ‑ test_torchscript_postproc_gpu[sequence_feature]
tests.integration_tests.test_torchscript ‑ test_torchscript_postproc_gpu[set_feature]
tests.integration_tests.test_torchscript ‑ test_torchscript_postproc_gpu[text_feature]
tests.integration_tests.test_torchscript ‑ test_torchscript_postproc_gpu[vector_feature]
tests.integration_tests.test_torchscript ‑ test_torchscript_preproc_gpu[audio_feature]
tests.integration_tests.test_torchscript ‑ test_torchscript_preproc_gpu[date_feature]
…
tests.ludwig.automl.test_base_config
tests.ludwig.automl.test_utils
tests.ludwig.backend.test_ray
tests.ludwig.benchmarking.test_profiler
tests.ludwig.data.test_ray_data
tests.ludwig.features.test_sequence_features ‑ test_sequence_preproc_module_bert_tokenizer
tests.ludwig.features.test_sequence_features ‑ test_sequence_preproc_module_clip_tokenizer
tests.ludwig.features.test_sequence_features ‑ test_sequence_preproc_module_gpt2bpe_tokenizer
tests.ludwig.features.test_sequence_features ‑ test_sequence_preproc_module_sentencepiece_tokenizer
tests.ludwig.utils.test_fs_utils ‑ test_get_fs_and_path_invalid_windows
…

@tgaddair tgaddair merged commit cd2c89c into master Apr 14, 2023
3 of 10 checks passed
@tgaddair tgaddair deleted the model-decoders branch April 14, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants