Fixed distributed strategy registration to be explicit #3361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abidwael
reviewed
Apr 24, 2023
| @@ -244,7 +245,7 @@ def tune_batch_size_fn( | |||
| # inside of a RayTrainer class, so we manually set the local_rank to 0 so that it picks up the right | |||
| # device to tune batch size on. | |||
| initialize_pytorch(local_rank=0, local_size=_local_size()) | |||
| distributed = get_current_dist_strategy(allow_local=True)() | |||
| distributed = init_dist_strategy("local") | |||
There was a problem hiding this comment.
Will this still be local after having merged #2934?
There was a problem hiding this comment.
Yes, good catch, we resolved this when merging the distirubted batch size tuning pr, so should be good:
https://github.com/ludwig-ai/ludwig/blob/master/ludwig/backend/ray.py#L249
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously were seeing issues were DDP was getting picked up even though FSDP was being selected.