Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to LocalStrategy for GBM metrics #3373

Merged
merged 16 commits into from
May 2, 2023
Merged

Conversation

abidwael
Copy link
Contributor

There's no initialized distributed strategy for GBM. We default to LocalStrategy to get the right gather_all_tensors_fn for GBM model metrics.

Fixing RuntimeError: Distributed strategy not initialized (type: RayTaskError(RuntimeError), retryable: true)

@justinxzhao
Copy link
Collaborator

Is there a test that you could add?

Copy link
Contributor

@jeffkinnison jeffkinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Echoing others: this looks good, just needs a test :)

ludwig/modules/metric_modules.py Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Apr 28, 2023

Unit Test Results

    6 files  ±    0      6 suites  ±0   3h 49m 15s ⏱️ + 1h 22m 3s
194 tests +  19  163 ✔️ +    6  31 💤 +13  0 ±0 
361 runs  +141  309 ✔️ +114  52 💤 +27  0 ±0 

Results for commit ee53bf1. ± Comparison against base commit aff6be7.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@tgaddair tgaddair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tests/integration_tests/test_gbm.py Show resolved Hide resolved
@abidwael abidwael merged commit 015ad28 into master May 2, 2023
3 of 4 checks passed
@abidwael abidwael deleted the dist-init-gbm-metrics branch May 2, 2023 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants