-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding --no-cache-dir to dockerfile pip install #3455
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Can we just confirm that creating the docker container from the dockerfile takes ~ the same amount of time? If yes, then I think LGTM!
Looks good to me when I ran it. Do you know why the tests are failing? |
Unit Test Results 6 files ± 0 6 suites ±0 50m 53s ⏱️ - 25m 25s For more details on these failures, see this check. Results for commit bc3a0fc. ± Comparison against base commit 8a5147d. This pull request removes 25 and adds 2735 tests. Note that renamed tests count towards both.
This pull request removes 1 skipped test and adds 8 skipped tests. Note that renamed tests count towards both.
|
@noyoshi yeah that was the culprit, feel free to either pull in master before merging or merge directly since your changes are unrelated! |
Code Pull Requests
Please provide the following:
--no-cache-dir
to pip installs within the Dockerfile. Without doing this, the pip cache adds around 2.5 GB uncompressed to the resulting containers.