Remove falcon from presets as it requires running untrusted code #3495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connor-mccorm
approved these changes
Aug 2, 2023
|
I know the current recommendation is to add a flag to make this work - is that not something we can do? |
|
Ycombinator news: https://news.ycombinator.com/item?id=36612627 I do believe this flag will be removed in the next transformers version |
arnavgarg1
approved these changes
Aug 2, 2023
|
Another idea: Check if the model architecture is RWForCausalLM and then conditionally add the trust-remote_code=True flag to the load kwargs. That way it'll only be supported for Falcon models. https://huggingface.co/tiiuae/falcon-40b/blob/main/config.json |
dennisrall
pushed a commit
to dennisrall/ludwig
that referenced
this pull request
Aug 9, 2023
dennisrall
pushed a commit
to dennisrall/ludwig
that referenced
this pull request
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.