Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mechanic to override default values for generation during model.predict() #3520

Merged
merged 2 commits into from
Aug 11, 2023

Conversation

justinxzhao
Copy link
Collaborator

Sample code:

model = LudwigModel(config=config, logging_level=logging.INFO)
results = model.train(training_set=dataset)
model.predict(dataset=dataset[:1], generation_config={"max_new_tokens": 513})

I've added additional logging statements to make it easier for testers/users to verify behavior.

@github-actions
Copy link

Unit Test Results

  6 files  ±0    6 suites  ±0   1h 7m 54s ⏱️ + 2m 41s
34 tests ±0  29 ✔️ ±0    5 💤 ±0  0 ±0 
88 runs  ±0  72 ✔️ ±0  16 💤 ±0  0 ±0 

Results for commit 1b6ee20. ± Comparison against base commit 92d07f6.

@arnavgarg1
Copy link
Contributor

LGTM, thanks for adding this!

As discussed offline, if the logging gets noisy, we can just change the logging.info to logging.debug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants