Move loss metric to same device as inputs #3522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnavgarg1
reviewed
Aug 11, 2023
| eval_loss, additional_losses = self.eval_loss(targets, predictions) | ||
| self.eval_loss_metric = self.eval_loss_metric.to(target_device) |
There was a problem hiding this comment.
Nice catch! Could you also do this for self.eval_additional_losses_metrics? I assume that may also require being moved to the right device (once we support multi-feature outputs for LLM model types, but might as well do it now)
arnavgarg1
approved these changes
Aug 11, 2023
arnavgarg1
reviewed
Aug 11, 2023
arnavgarg1
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously: evaluation loss metric could be on a different device than inputs
Now: evaluation loss metric moved to same device as inputs