Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to upload Ludwig models to Predibase. #3687

Merged
merged 16 commits into from
Oct 11, 2023

Conversation

martindavis
Copy link
Contributor

@martindavis martindavis commented Oct 4, 2023

Adds the ability for Ludwig users to upload their models to Predibase.

ludwig upload predibase -r "test_repo_ludwig_cli_2" -m /path/to/results/experiment_run_0/ -df /path/to/dataset.csv
Connected to Predibase as User(id=123, username=martin)
Dataset name was not explicitly provided. Defaulting to: reuters
Uploading dataset...
Dataset uploaded.
Created model repository: <test_repo_ludwig_cli_2>
presigned_url {'url': 'https://s3.us-west-2.amazonaws.com/some-bucket-name/presigned-url', 'headers': None}
Model uploaded to Predibase with repository name `test_repo_ludwig_cli`

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Unit Test Results

  6 files  ±  0    6 suites  ±0   20m 58s ⏱️ - 19m 19s
12 tests  - 19    9 ✔️  - 17    3 💤  - 2  0 ±0 
60 runs   - 22  42 ✔️  - 24  18 💤 +2  0 ±0 

Results for commit 72935aa. ± Comparison against base commit e46a989.

This pull request removes 19 tests.
tests.integration_tests.test_cli ‑ test_reproducible_cli_runs[horovod-experiment-1919-0]
tests.integration_tests.test_cli ‑ test_reproducible_cli_runs[horovod-experiment-1919-1]
tests.integration_tests.test_cli ‑ test_reproducible_cli_runs[horovod-experiment-31-0]
tests.integration_tests.test_cli ‑ test_reproducible_cli_runs[horovod-experiment-31-1]
tests.integration_tests.test_cli ‑ test_reproducible_cli_runs[horovod-train-1919-0]
tests.integration_tests.test_cli ‑ test_reproducible_cli_runs[horovod-train-1919-1]
tests.integration_tests.test_cli ‑ test_reproducible_cli_runs[horovod-train-31-0]
tests.integration_tests.test_cli ‑ test_reproducible_cli_runs[horovod-train-31-1]
tests.integration_tests.test_cli ‑ test_train_cli_horovod
tests.integration_tests.test_horovod ‑ test_horovod_gpu_memory_limit
…

♻️ This comment has been updated with latest results.

@martindavis martindavis marked this pull request as ready for review October 6, 2023 14:38
requirements.txt Outdated Show resolved Hide resolved
Copy link
Collaborator

@justinxzhao justinxzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reasonable test that we can write for this?

ludwig/utils/upload_utils.py Show resolved Hide resolved
@martindavis
Copy link
Contributor Author

Is there a reasonable test that we can write for this?

Great question @justinxzhao ! @arnavgarg1 and I talked about adding an integration test in the CI to make sure that this works for both HF and Predibase. Our plan is to tackle that late next week!

@tgaddair tgaddair merged commit 7c3a549 into master Oct 11, 2023
17 checks passed
@tgaddair tgaddair deleted the add-pbase-upload-model-command branch October 11, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants