Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Use Trusted Publishers credentials instead of User/Password for uploading releases to PyPi #3892

Conversation

alexsherstinsky
Copy link
Collaborator

Scope

PyPi finally discontinued the use of user/password credentials for publishing releases; the sanctioned approach is called "Trusted Publishers" ("https://docs.pypi.org/trusted-publishers/"). Hence, this change updates the corresponding GitHub actions pipeline.

Code Pull Requests

Please provide the following:

  • a clear explanation of what your code does
  • if applicable, a reference to an issue
  • a reproducible test for your PR (code, config and data sample)

Documentation Pull Requests

Note that the documentation HTML files are in docs/ while the Markdown sources are in mkdocs/docs.

If you are proposing a modification to the documentation you should change only the Markdown files.

api.md is automatically generated from the docstrings in the code, so if you want to change something in that file, first modify ludwig/api.py docstring, then run mkdocs/code_docs_autogen.py, which will create mkdocs/docs/api.md .

Copy link

Unit Test Results

  6 files  ±0    6 suites  ±0   14m 15s ⏱️ -9s
12 tests ±0    9 ✔️ ±0    3 💤 ±0  0 ±0 
60 runs  ±0  42 ✔️ ±0  18 💤 ±0  0 ±0 

Results for commit d30b065. ± Comparison against base commit 31a3957.

Copy link
Collaborator

@justinxzhao justinxzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@alexsherstinsky alexsherstinsky merged commit 678ee78 into master Jan 17, 2024
18 checks passed
@alexsherstinsky alexsherstinsky deleted the alexsherstinsky/maintenance/update_pypi_upload_to_use_trusted_publishers_instead_of_user_password_credentials_2024_01_16 branch January 17, 2024 07:30
vijayi1 pushed a commit to vijayi1/ludwig that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants