Enable AdaLoRA tests for LLM adapter #3896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffkinnison
requested review from
w4nderlust,
tgaddair,
justinxzhao,
arnavgarg1,
geoffreyangus,
Infernaught and
alexsherstinsky
as code owners
arnavgarg1
approved these changes
Jan 18, 2024
|
@jeffkinnison Actually I think it was a transient failure, so should be good to merge, especially given that your tests don't touch either module and you only added new tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds adalora to the list of adapters available to
LLMEncoderand adds adalora to the existing test suite.