Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast LLMEncoder output to torch.float32, freeze final layer at init. #3900

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

jeffkinnison
Copy link
Contributor

LLMEncoder fine-tuning is currently blocked by two issues:

This PR adds fixes for both issues:

  • LLMEncoder output is now explicitly cast to torch.float32
  • The final layer of the base model is always frozen in LLMEncoder.__init__

Copy link

Unit Test Results

  6 files  ±0    6 suites  ±0   14m 27s ⏱️ +16s
12 tests ±0    9 ✔️ ±0    3 💤 ±0  0 ±0 
60 runs  ±0  42 ✔️ ±0  18 💤 ±0  0 ±0 

Results for commit 6721dfc. ± Comparison against base commit ea50811.

@jeffkinnison jeffkinnison merged commit 27c6079 into master Jan 19, 2024
18 checks passed
@jeffkinnison jeffkinnison deleted the llm-encoder-dtype-mismatch branch January 19, 2024 18:36
vijayi1 pushed a commit to vijayi1/ludwig that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants