Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Always return a list of quantization bits values from get_quantization #3926

Merged
merged 3 commits into from
Feb 9, 2024
Merged

fix: Always return a list of quantization bits values from get_quantization #3926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9db25df
only return a list of quantization bits values
jeffkinnison Feb 8, 2024
4ccc94b
return lists for missing quantization
jeffkinnison Feb 8, 2024
b958a34
update to check for lists
jeffkinnison Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ludwig/utils/config_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ def config_uses_llm(config: Union[Dict[str, Any], ModelConfig]) -> bool:
return uses_llm


def get_quantization(config: Union[Dict[str, Any], ModelConfig]) -> Union[int, List[int], None]:
def get_quantization(config: Union[Dict[str, Any], ModelConfig]) -> List[Union[int, None]]:
"""Get the quantization specified in a config at any level.

Args:
Expand All @@ -157,7 +157,7 @@ def get_quantization(config: Union[Dict[str, Any], ModelConfig]) -> Union[int, L
"""
if isinstance(config, ModelConfig):
if config.model_type == MODEL_LLM:
return config.quantization.bits if config.quantization else None
return [config.quantization.bits] if config.quantization else [None]
else:
quantization_bits = []
for feature in config.input_features:
Expand All @@ -169,7 +169,7 @@ def get_quantization(config: Union[Dict[str, Any], ModelConfig]) -> Union[int, L
return quantization_bits
elif isinstance(config, dict) and config:
if config.get(MODEL_TYPE, MODEL_ECD) == MODEL_LLM:
return config.get("quantization", {}).get("bits")
return [config.get("quantization", {}).get("bits")]
elif INPUT_FEATURES in config:
quantization_bits = []
for feature in config.get(INPUT_FEATURES, []):
Expand Down
6 changes: 3 additions & 3 deletions tests/ludwig/utils/test_config_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,9 +246,9 @@ def ecd_config_dict_llm_encoder_8bit(
"config,expectation",
[
# LLM configurations
("llm_config_dict", None),
("llm_config_dict_4bit", 4),
("llm_config_dict_8bit", 8),
("llm_config_dict", [None]),
("llm_config_dict_4bit", [4]),
("llm_config_dict_8bit", [8]),
# LLM encoder configurations with one feature
("ecd_config_dict_llm_encoder", [None]),
("ecd_config_dict_llm_encoder_4bit", [4]),
Expand Down
Loading