Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling AdaptionPrompt till PEFT is fixed. #3935

Conversation

alexsherstinsky
Copy link
Collaborator

Scope

We are disabling AdaptionPrompt temporarily, until incompatibility with the forward() signature in HuggingFace PEFT is fixed.

Code Pull Requests

Please provide the following:

  • a clear explanation of what your code does
  • if applicable, a reference to an issue
  • a reproducible test for your PR (code, config and data sample)

Documentation Pull Requests

Note that the documentation HTML files are in docs/ while the Markdown sources are in mkdocs/docs.

If you are proposing a modification to the documentation you should change only the Markdown files.

api.md is automatically generated from the docstrings in the code, so if you want to change something in that file, first modify ludwig/api.py docstring, then run mkdocs/code_docs_autogen.py, which will create mkdocs/docs/api.md .

Copy link

github-actions bot commented Feb 21, 2024

Unit Test Results

       4 files  ±       0         4 suites  ±0   27m 3s ⏱️ + 17m 25s
2 984 tests +2 972  2 971 ✔️ +2 962  12 💤 +9  1 +1 
3 000 runs  +2 960  2 981 ✔️ +2 953  18 💤 +6  1 +1 

For more details on these failures, see this check.

Results for commit 8be567d. ± Comparison against base commit ea890d9.

♻️ This comment has been updated with latest results.

@arnavgarg1 arnavgarg1 merged commit cde34ef into master Feb 22, 2024
13 of 18 checks passed
@arnavgarg1 arnavgarg1 deleted the bugfix/alexsherstinsky/disable_adaption_prompt_while_waiting_for_peft_fix-2024_02_21-26 branch February 22, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants