Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor change to fix the incorrect response truncation #3986

Merged

Conversation

amankhandelia
Copy link
Contributor

Following code changes fixes the bug identified in #3985

Copy link
Collaborator

@alexsherstinsky alexsherstinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great -- just would hope to also include a test. Thank you!

@amankhandelia
Copy link
Contributor Author

@alexsherstinsky, have added a regression test case for the fix. Please review the same.

Copy link
Collaborator

@alexsherstinsky alexsherstinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexsherstinsky
Copy link
Collaborator

@amankhandelia thank you very much -- approved; will be in the release coming later today!

@alexsherstinsky alexsherstinsky merged commit f28a3c5 into ludwig-ai:master Apr 8, 2024
1 check passed
@amankhandelia amankhandelia deleted the fix_response_truncation branch May 3, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants