Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature jurij #88

Merged
merged 14 commits into from Jun 11, 2020
Merged

Feature jurij #88

merged 14 commits into from Jun 11, 2020

Conversation

kevinstratford
Copy link
Collaborator

I've made a couple of changes.

  1. The default force method needs to be divergence for tests to pass.
  2. The flux kernel in the Cahn Hilliard is repaired for the GPU version
  3. Redundant comments removed.

@kevinstratford
Copy link
Collaborator Author

We need to add a test.
We need to add documentation.

@kevinstratford
Copy link
Collaborator Author

I've added documentation under "Force on fluid" (not public yet).

@kevinstratford kevinstratford merged commit fa0ec39 into develop Jun 11, 2020
@kevinstratford kevinstratford deleted the feature-jurij branch June 11, 2020 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kevinstratford @jurijsab