3.x: don’t include editline/readline.h, use the embedded readline #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building for a Python whose own readline module has been configured to use editline, WITH_EDITLINE will be defined during the python-gnureadline build, by virtue of its inclusion of "pyconfig.h" (via "Python.h"). This macro being defined caused python-gnureadline to a problem because python-gnureadline is expecting and has configured itself to use its own embedded copy of GNU readline. This removes the HAVE_EDITLINE branch to allow the expected readline headers to be included. See https://trac.macports.org/ticket/68265.
Merged
12 tasks
|
Thanks Mark, closed as this is included in #71. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building for a Python whose own readline module has been configured to use editline,
WITH_EDITLINEwill be defined during the python-gnureadline build, by virtue of its inclusion of "pyconfig.h" (via "Python.h"). This macro being defined caused python-gnureadline to a problem because python-gnureadline is expecting and has configured itself to use its own embedded copy of GNU readline.This removes the
HAVE_EDITLINEbranch to allow the expected readline headers to be included.See https://trac.macports.org/ticket/68265.