Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't work as is because these functions won't be defined unless WooCommerce is active.
Also, the
ignores
here takes a list of URL strings. But the value being passed intopreg_quote()
will end up being a boolean, so it's not going to work.So what is needed is:
function_exists( 'is_woocommerce' )
.ignores
.Additionally, I don't think this should be done directly here. Instead, the patterns should be added in a separate WooCommerce-specific filter:
This could be in a separate file entirely, like
plugin-compat/woocommerce.php
so make it scalable for wider compatibility in the ecosystem.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works for me
Sorry, I'm not an expert on php. It is clear that your solution is a better way