Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite retries and potential log entries lost upon delivery failure #284

Closed
JayBeavers opened this issue Sep 9, 2021 · 2 comments
Closed
Assignees
Labels

Comments

@JayBeavers
Copy link

JayBeavers commented Sep 9, 2021

Describe the problem to solve
My quick read of MessageTransmitter is that undelivered messages will infinitely queue in RAM as SendMessageAsync recursively calls itself upon delivery failure. This would mean that queues build up to memory exhaustion and pending messages are lost on process exit if I'm reading it correctly.

Describe the feature proposed
It would be beneficial to adopt a retry mechanism, potentially with an exponential backoff delay, which is triggered by delivery issues. This target could also use a size and time limited local file system persistence store for messages which were not delivered, so that they can be transmitted when there are no more delivery issues.

@luigiberrettini luigiberrettini changed the title Persistent retransmission queue Delivery issues result in lost log entries Sep 11, 2021
@luigiberrettini luigiberrettini changed the title Delivery issues result in lost log entries Infinite retries and potential log entries lost upon delivery failure Sep 11, 2021
@luigiberrettini
Copy link
Owner

Closing this issue after split.

@JayBeavers
Copy link
Author

Thank you. Good call splitting into two items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants