Skip to content

Commit

Permalink
Updated code doc
Browse files Browse the repository at this point in the history
  • Loading branch information
Luis Leiva committed Dec 17, 2017
1 parent 2698817 commit e5f4674
Show file tree
Hide file tree
Showing 10 changed files with 51 additions and 24 deletions.
2 changes: 1 addition & 1 deletion jquery.sketchable.animate.js
Expand Up @@ -137,7 +137,7 @@
var events = 'clear destroy'.split(' ');
for (var i = 0; i < events.length; i++) {
var evName = events[i];
$instance.sketchable('decorateEvent', evName, callbacks[evName], 'animate');
$instance.sketchable('decorate', evName, callbacks[evName], 'animate');
}

// Expose public API: all jQuery sketchable instances will have these methods.
Expand Down
8 changes: 7 additions & 1 deletion jquery.sketchable.js
Expand Up @@ -212,8 +212,14 @@
* @param {string} evName - Event name.
* @param {function} listener - Custom event listener.
* @param {string} initiator - Some identifier.
* @return jQuery
* @memberof $.fn.sketchable
* @example
* // Decorate 'clear' method with `myClearFn()`,
* // using 'someId' to avoid collisions with other decorators.
* $('canvas').sketchable('decorate', 'clear', myClearFn, 'someId');
*/
decorateEvent: function(evName, listener, initiator) {
decorate: function(evName, listener, initiator) {
return this.each(function() {
var elem = $(this), data = elem.data(namespace), options = data.options;
// Flag event override so that it doesn't get fired more than once.
Expand Down
2 changes: 1 addition & 1 deletion jquery.sketchable.memento.js
Expand Up @@ -188,7 +188,7 @@
var events = 'mouseup clear destroy'.split(' ');
for (var i = 0; i < events.length; i++) {
var evName = events[i];
$instance.sketchable('decorateEvent', evName, callbacks[evName], 'memento');
$instance.sketchable('decorate', evName, callbacks[evName], 'memento');
}

// Expose public API: all jQuery sketchable instances will have these methods.
Expand Down
17 changes: 10 additions & 7 deletions jquery.sketchable.svg.js
Expand Up @@ -9,9 +9,9 @@
// Custom namespace ID, for private data bindind.
var namespace = 'sketchable';
/**
* Memento plugin constructor for jQuery Sketchable instances.
* SVG plugin constructor for jQuery Sketchable instances.
* @param {jQuery} $instance - jQuery sketchable instance.
* @namespace $.fn.sketchable.plugins.memento
* @namespace $.fn.sketchable.plugins.svg
*/
$.fn.sketchable.plugins.svg = function($instance) {
// Access the instance configuration.
Expand All @@ -31,7 +31,7 @@
var events = 'clear destroy'.split(' ');
for (var i = 0; i < events.length; i++) {
var evName = events[i];
$instance.sketchable('decorateEvent', evName, callbacks[evName], 'svg');
$instance.sketchable('decorate', evName, callbacks[evName], 'svg');
}

// Expose public API: all jQuery sketchable instances will have these methods.
Expand All @@ -40,10 +40,13 @@
svg: {
/**
* Generate SVG.
* @param {function} callback - Callback function, executed with the SVG as argument.
* @return {Sketchable} Sketchable instance.
* @memberof Sketchable.plugins.memento
* @example sketchableInstance.memento.undo();
* @param {function} callback - Callback function, executed with the SVG (string) as argument.
* @return {jQuery} jQuery sketchable element.
* @memberof $.fn.sketchable.plugins.svg
* @example
* jqueryElem.sketchable('svg.create', function(contents) {
* // Do something with the SVG string.
* });
*/
create: function(callback) {
var data = $(this).data(namespace);
Expand Down
3 changes: 3 additions & 0 deletions jsdoc.json
Expand Up @@ -2,13 +2,16 @@
"source": {
"include": [
"jsketch.js",
"jsketch.svg.js",
"sketchable.js",
"sketchable.utils.js",
"sketchable.memento.js",
"sketchable.animate.js",
"sketchable.svg.js",
"jquery.sketchable.js",
"jquery.sketchable.memento.js",
"jquery.sketchable.animate.js",
"jquery.sketchable.svg.js",
"README.md"
]
},
Expand Down
9 changes: 7 additions & 2 deletions jsketch.svg.js
Expand Up @@ -13,9 +13,12 @@
;(function(window) {
/**
* Convert jSketch canvas to SVG.
* @param {function} callback - Callback function, executed when SVG is ready.
* @return {string}
* This method is asynchronous, and will be invoked when the SVG is ready.
* @param {function} callback - Callback function, to be invoked with the SVG (string) as argument.
* @return {jSketch}
* @memberof jSketch
* @method
* @name toSVG
*/
window.jSketch.prototype.toSVG = function(callback) {
// Save pointer for use in closures.
Expand Down Expand Up @@ -239,6 +242,8 @@
console.info('Waiting for queue to be empty:', asyncQueue);
}
}

return this;
};

})(this);
4 changes: 2 additions & 2 deletions sketchable.animate.js
Expand Up @@ -139,7 +139,7 @@
var events = 'clear destroy'.split(' ');
for (var i = 0; i < events.length; i++) {
var evName = events[i];
instance.decorateEvent(evName, callbacks[evName], 'animate');
instance.decorate(evName, callbacks[evName], 'animate');
}

// Expose public API: all Sketchable instances will have these methods.
Expand All @@ -148,7 +148,7 @@
animate: {
/**
* Animate canvas strokes.
* @return {Sketchable} instance Sketchable element.
* @return {Sketchable} Sketchable element.
* @memberof Sketchable.plugins.animate
* @example sketchableInstance.strokes(strokeArray).animate.strokes();
* @example
Expand Down
9 changes: 8 additions & 1 deletion sketchable.js
Expand Up @@ -241,8 +241,15 @@
* @param {string} evName - Event name.
* @param {function} listener - Custom event listener.
* @param {string} initiator - Some identifier.
* @return {Sketchable}
* @memberof Sketchable
* @example
* var sketcher = new Sketchable('#my-canvas');
* // Decorate 'clear' method with `myClearFn()`,
* // using 'someId' to avoid collisions with other decorators.
* sketcher.decorate('clear', myClearFn, 'someId');
*/
decorateEvent: function(evName, listener, initiator) {
decorate: function(evName, listener, initiator) {
var elem = this.elem, data = dataBind(elem)[namespace], options = data.options;
// Flag event override so that it doesn't get fired more than once.
var overrideId = '_bound$'+ evName + '.' + initiator;
Expand Down
2 changes: 1 addition & 1 deletion sketchable.memento.js
Expand Up @@ -190,7 +190,7 @@
var events = 'mouseup clear destroy'.split(' ');
for (var i = 0; i < events.length; i++) {
var evName = events[i];
instance.decorateEvent(evName, callbacks[evName], 'memento');
instance.decorate(evName, callbacks[evName], 'memento');
}

// Expose public API: all Sketchable instances will have these methods.
Expand Down
19 changes: 11 additions & 8 deletions sketchable.svg.js
Expand Up @@ -11,9 +11,9 @@
// Custom namespace ID, for private data bindind.
var namespace = 'sketchable';
/**
* Memento plugin constructor for Sketchable instances.
* SVG plugin constructor for Sketchable instances.
* @param {Sketchable} instance - Sketchable element.
* @namespace Sketchable.plugins.memento
* @namespace Sketchable.plugins.svg
*/
Sketchable.prototype.plugins.svg = function(instance) {
// Access the instance configuration.
Expand All @@ -33,19 +33,22 @@
var events = 'clear destroy'.split(' ');
for (var i = 0; i < events.length; i++) {
var evName = events[i];
instance.decorateEvent(evName, callbacks[evName], 'svg');
instance.decorate(evName, callbacks[evName], 'svg');
}

// Expose public API: all Sketchable instances will have these methods.
deepExtend(instance, {
// Namespace methods to avoid collisions with other plugins.
svg: {
/**
/**
* Generate SVG.
* @param {function} callback - Callback function, executed with the SVG as argument.
* @return {Sketchable} Sketchable instance.
* @memberof Sketchable.plugins.memento
* @example sketchableInstance.memento.undo();
* @param {function} callback - Callback function, executed with the SVG (string) as argument.
* @return {Sketchable} Sketchable element.
* @memberof Sketchable.plugins.svg
* @example
* sketchableInstance.svg.create(function(contents) {
* // Do something with the SVG string.
* });
*/
create: function(callback) {
var data = dataBind(instance.elem)[namespace];
Expand Down

0 comments on commit e5f4674

Please sign in to comment.