Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Ruby #44

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Upgrade Ruby #44

wants to merge 3 commits into from

Conversation

rvandernoort
Copy link
Contributor

@rvandernoort rvandernoort commented Mar 5, 2023

I have not used Ruby a lot, so I can't say for sure this works without breaking anything, but it seems to work. I was on a version before this commit and instead of downgrading I upgraded to the latest version of ruby and jekyll, which required a fresh lockfile.

Also added the webrick dependency since it originally failed with the following error solved with this thread

bundler: failed to load command: jekyll (/usr/local/bundle/bin/jekyll)
<internal:/usr/local/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:37:in `require': cannot load such file -- webrick (LoadError)

Only issue I seem to have left with the docker is that when you ctrl-c it freezes and I have to manually stop the container in another terminal, but this might just be my machine. Updated README to include -it parameters for interactivity for developers.

@rvandernoort rvandernoort marked this pull request as ready for review March 5, 2023 22:07
@luiscruz
Copy link
Owner

luiscruz commented Mar 6, 2023

Hi Rover @rvandernoort , thanks for the contribution! I really appreciate it. If that's ok, I'll look into it later this week. Cheers, L.

@olepbr
Copy link
Contributor

olepbr commented Mar 7, 2023

Only issue I seem to have left with the docker is that when you ctrl-c it freezes and I have to manually stop the container in another terminal, but this might just be my machine.

This is due to -it (--interactive --tty) not being included in the docker run command; without it, the container can't hear your Ctrl+C :–)

@rvandernoort
Copy link
Contributor Author

This is due to -it (--interactive --tty) not being included in the docker run command; without it, the container can't hear your Ctrl+C :–)

Of course thanks for the refresher! I'll update the README to include those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants