-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to CLI-based tool, multithread download, better error handling #5
Open
Midnight145
wants to merge
15
commits into
luiseduardobr1:master
Choose a base branch
from
Midnight145:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed regex for HathiTrust links as sometimes the document is of the format 'abcd.a9999999'. Original regex was only looking for digits in the second part of the id and would to get the correct document.
Great work! |
Fix regex for HathiTrust links.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tool is now command-line based, instead of modifying the link variable directly.
Configurable output path
link,output_path
Removes temporary pages by default
Book splicing can be done with flags instead of modifying variables directly
Uses
os.path.join
instead of hardcoded UNIX-based pathsThe main download is multithreaded to download multiple files at once, useful for larger books
Retries failed downloads several times and will sleep for a few seconds in case of 429 Too many requests
In the event of missing pages, you get a prompt at the end where you can force continue, download manually, or attempt to redownload automatically (single-threaded)