Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix production build #28

Merged
merged 4 commits into from
Jun 26, 2023
Merged

Fix production build #28

merged 4 commits into from
Jun 26, 2023

Conversation

luisherranz
Copy link
Owner

What

  1. Fix the production tests, which were not passing correctly
  2. Fix the ownKeys trap, which was not working in production
  3. Fix the peek function, which was not working in production

Why

Because the production tests were broken.

How

  1. Filter correctly the deepsignal packages in Karma.
  2. Reassing the value to itself to prevent the JS minifier from removing the .value access.
  3. Wrap the last flag in a try/catch to prevent the JS minifier from reordering the assignments.

@luisherranz luisherranz self-assigned this Jun 26, 2023
@github-actions
Copy link
Contributor

Size Change: +105 B (+2%)

Total Size: 6.2 kB

Filename Size Change
packages/deepsignal/core/dist/deepsignal-core.js 1.01 kB +18 B (+2%)
packages/deepsignal/core/dist/deepsignal-core.mjs 1 kB +17 B (+2%)
packages/deepsignal/dist/deepsignal.js 1.05 kB +20 B (+2%)
packages/deepsignal/dist/deepsignal.mjs 1.04 kB +16 B (+2%)
packages/deepsignal/react/dist/deepsignal-react.js 1.05 kB +19 B (+2%)
packages/deepsignal/react/dist/deepsignal-react.mjs 1.04 kB +15 B (+1%)

compressed-size-action

@luisherranz luisherranz marked this pull request as ready for review June 26, 2023 11:08
@luisherranz luisherranz linked an issue Jun 26, 2023 that may be closed by this pull request
@luisherranz luisherranz merged commit ff7d151 into main Jun 26, 2023
3 checks passed
@luisherranz luisherranz deleted the fix-production-build branch June 26, 2023 11:19
@github-actions github-actions bot mentioned this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: get informed about insertion/removal of properties
1 participant