Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent any type of class instances #46

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Conversation

luisherranz
Copy link
Owner

@luisherranz luisherranz commented Sep 20, 2023

What

This is built on top of #38.

Prevent wrapping class instances and everything that is not strictly plain objects or arrays.

Why

I'd like to try to keep the library as simple as possible and see if supporting only plain objects and array fulfills its state management purpose. If it doesn't, I may try to include support again in the future.

How

By not wrapping anything that doesn't have an Object or Array constructor.

@luisherranz luisherranz self-assigned this Sep 20, 2023
@luisherranz luisherranz mentioned this pull request Sep 20, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2023

Size Change: 0 B

Total Size: 6.12 kB

ℹ️ View Unchanged
Filename Size
packages/deepsignal/core/dist/deepsignal-core.js 1 kB
packages/deepsignal/core/dist/deepsignal-core.mjs 990 B
packages/deepsignal/dist/deepsignal.js 1.03 kB
packages/deepsignal/dist/deepsignal.mjs 1.03 kB
packages/deepsignal/react/dist/deepsignal-react.js 1.03 kB
packages/deepsignal/react/dist/deepsignal-react.mjs 1.03 kB

compressed-size-action

Because class support was never intended nor functional
@luisherranz
Copy link
Owner Author

I'm waiting until #38 is merged to merge this.

Copy link
Collaborator

@DAreRodz DAreRodz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👌

Base automatically changed from shallow to main January 31, 2024 12:48
@luisherranz luisherranz merged commit d50eeaa into main Jan 31, 2024
3 checks passed
@luisherranz luisherranz deleted the unsupported-data-structures branch January 31, 2024 14:23
@github-actions github-actions bot mentioned this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants