Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color palettes #37

Merged
merged 2 commits into from
Oct 24, 2022
Merged

Color palettes #37

merged 2 commits into from
Oct 24, 2022

Conversation

crzdg
Copy link
Contributor

@crzdg crzdg commented Oct 1, 2022

Hi!

I created a python script which creates the palettes of the colors for the different intensity maps.

To run you need svgwrite installed.

This should help to maintain the README.
If somebody could add an exporter of the actual lua colors to the python dict used in this script, this would be awesome.
Unfortunately, I do not know any lua beyond nvim config.

Also, I rearrange the README a little bit.

Feel free to add some suggestions!

Addresses,

#15 and #31

Have a look on the new README here: https://github.com/crzdg/gruvbox-baby/tree/svg-palettes

@crzdg crzdg force-pushed the svg-palettes branch 3 times, most recently from 4ef0473 to 72a5803 Compare October 1, 2022 16:04
@luisiacc
Copy link
Owner

luisiacc commented Oct 2, 2022

Hi there!

It's amazing to see this, thank you! It looks really good.

One small thing: Currently the color palette is the same for all intensities, so it feels kind of repetitive to add the same palette 4 times, when it's really most of the same colors, only some changes in the background colors.

README.md Show resolved Hide resolved
@crzdg
Copy link
Contributor Author

crzdg commented Oct 4, 2022

Hi there!

It's amazing to see this, thank you! It looks really good.

One small thing: Currently the color palette is the same for all intensities, so it feels kind of repetitive to add the same palette 4 times, when it's really most of the same colors, only some changes in the background colors.

I thought the same here as well. In the end, I decided to add all the images to the README, as they all have a different (image) background color (the actually used background-color) so you see the color palette in contrast to the background-color. IMHO, this is important for the user so the palettes actually can be compared.

I agree that most colors are repeated, but for me, the contrast of the colors to the background is an important piece of information.

Maybe we can agree on using an expandable (https://gist.github.com/pierrejoubert73/902cc94d79424356a8d20be2b382e1ab) for the different images?

Also, I was thinking of adding an image that shows the differences between the actually changed colors (dark, background, etc...). So the user can see what shades are used in the different modes.

So in the end the README will contain an image of the medium color palette in expanded mode and an image showing the different shades side-by-side. The palettes for dark, soft, soft_flat will be added as well but are collapsed by default.

What do you think?

@luisiacc
Copy link
Owner

luisiacc commented Oct 5, 2022

Hi there, sry for the late response, I'm traveling so I don't get much time with internet.

I agree that most colors are repeated, but for me, the contrast of the colors to the background is an important piece of information.

Yeah I agree that the contrast of the colors with the background is important, however that's visible when the colors are seen as code(like on a code screenshot), when you put them as rectangles like the way it is now, that contrast is not really appreciated(At least I didn't see any noticeable difference), after all, the objective of showing the palette is just a way for the user to be able to quickly copy/paste them, therefore having them repeated doesn't make much sense IMO.

Also, I was thinking of adding an image that shows the differences between the actually changed colors (dark, background, etc...). So the user can see what shades are used in the different modes.
So in the end the README will contain an image of the medium color palette in expanded mode and an image showing the different shades side-by-side. The palettes for dark, soft, soft_flat will be added as well but are collapsed by default.

OK this sounds good!, although I remain a bit skeptical about having the colors repeated, I love the idea of having the different shades side-by-side.

@crzdg
Copy link
Contributor Author

crzdg commented Oct 6, 2022

Hey,

No problem.

I will push a suggestion over the weekend. Then we can have the next discussion.
Maybe, we will improve it a little now, and then we do an iteration on it.

@crzdg crzdg force-pushed the svg-palettes branch 10 times, most recently from db3319f to 536be0e Compare October 16, 2022 08:20
@mrdgo
Copy link

mrdgo commented Oct 18, 2022

Shouldn't you upload media files somewhere else than github?
As a user of this colorscheme, I would like to not have to have the .svg files on my machine.

@luisiacc
Copy link
Owner

As a user of this colorscheme, I would like to not have to have the .svg files on my machine.

They are 8kbs each, so you wouldn't even notice them.

@crzdg crzdg force-pushed the svg-palettes branch 2 times, most recently from b11bc12 to 52f1439 Compare October 22, 2022 08:46
@crzdg
Copy link
Contributor Author

crzdg commented Oct 22, 2022

@luisiacc

Sorry I was sick the last days and was not able to update this earlier.

OK, I changed quite some things with the new commits.

  • First of all, I added a .gitignore. I copied the content of the GitHub Lua and Python .gitignore. I hope this is OK with you?
  • In the README I added emojis for all the headers. I also moved back the info about the terminal and the font back to the Pretty Pictures section. But instead below an separate header I added it right after the Pretty Pictures header.

The main change still would be the Palette section.
I added as you have already seen the different palettes of the intensities. But put them in a expandable.
Further, a image showing the different shades of the intensities, as discussed.
And a table with the colors, its names and hex-values.

Have a look at the README here,

https://github.com/crzdg/gruvbox-baby/tree/svg-palettes

I guess we should discuss, how the added content should be organized. The linked README shows my proposal for it.
I'm happy to heare your idea of how it should be organized.

@crzdg crzdg requested a review from luisiacc October 22, 2022 08:49
Copy link
Owner

@luisiacc luisiacc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I was sick the last days and was not able to update this earlier.

Hey no worries, hope that you're fine now!

I see this very good now, I think we can merge it.

@luisiacc luisiacc merged commit 8a11460 into luisiacc:main Oct 24, 2022
@crzdg crzdg deleted the svg-palettes branch October 24, 2022 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants