-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color palettes #37
Color palettes #37
Conversation
4ef0473
to
72a5803
Compare
Hi there! It's amazing to see this, thank you! It looks really good. One small thing: Currently the color palette is the same for all intensities, so it feels kind of repetitive to add the same palette 4 times, when it's really most of the same colors, only some changes in the background colors. |
I thought the same here as well. In the end, I decided to add all the images to the I agree that most colors are repeated, but for me, the contrast of the colors to the background is an important piece of information. Maybe we can agree on using an Also, I was thinking of adding an image that shows the differences between the actually changed colors ( So in the end the README will contain an image of the medium color palette in expanded mode and an image showing the different shades side-by-side. The palettes for What do you think? |
Hi there, sry for the late response, I'm traveling so I don't get much time with internet.
Yeah I agree that the contrast of the colors with the background is important, however that's visible when the colors are seen as code(like on a code screenshot), when you put them as rectangles like the way it is now, that contrast is not really appreciated(At least I didn't see any noticeable difference), after all, the objective of showing the palette is just a way for the user to be able to quickly copy/paste them, therefore having them repeated doesn't make much sense IMO.
OK this sounds good!, although I remain a bit skeptical about having the colors repeated, I love the idea of having the different shades side-by-side. |
Hey, No problem. I will push a suggestion over the weekend. Then we can have the next discussion. |
db3319f
to
536be0e
Compare
Shouldn't you upload media files somewhere else than github? |
They are 8kbs each, so you wouldn't even notice them. |
b11bc12
to
52f1439
Compare
Sorry I was sick the last days and was not able to update this earlier. OK, I changed quite some things with the new commits.
The main change still would be the Have a look at the README here, https://github.com/crzdg/gruvbox-baby/tree/svg-palettes I guess we should discuss, how the added content should be organized. The linked |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I was sick the last days and was not able to update this earlier.
Hey no worries, hope that you're fine now!
I see this very good now, I think we can merge it.
Hi!
I created a python script which creates the palettes of the colors for the different intensity maps.
To run you need
svgwrite
installed.This should help to maintain the README.
If somebody could add an exporter of the actual lua colors to the python dict used in this script, this would be awesome.
Unfortunately, I do not know any lua beyond nvim config.
Also, I rearrange the README a little bit.
Feel free to add some suggestions!
Addresses,
#15 and #31
Have a look on the new README here: https://github.com/crzdg/gruvbox-baby/tree/svg-palettes