Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: config option 'overrides' to override palette colors #40

Merged
merged 5 commits into from
Oct 24, 2022
Merged

feat: config option 'overrides' to override palette colors #40

merged 5 commits into from
Oct 24, 2022

Conversation

gaoDean
Copy link
Contributor

@gaoDean gaoDean commented Oct 24, 2022

First of all, I love this variation of gruvbox, works better than any other out there, thanks for putting in the effort to create this.

I didn't like the dark blue in the palette, so this allows you to override any palette color with another color

vim.g.gruvbox_baby_overrides = {blue_gray = "#aaaaaa"}

or using existing palette colors

vim.g.gruvbox_baby_overrides = {blue_gray = "light_blue"}

Copy link
Owner

@luisiacc luisiacc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent suggestion, thank you!

Just a few details and we can merge this.

lua/gruvbox-baby/config.lua Outdated Show resolved Hide resolved
lua/gruvbox-baby/colors.lua Outdated Show resolved Hide resolved
* "I think is better if we remove this option, we already provide a way for getting the colors with require("gruvbox-baby.colors").config(), so if anyone wants to use some of the existing colors they can do it that way. Also we don't have to deal with strings that don't match the keys on the colors dictionary."
@gaoDean
Copy link
Contributor Author

gaoDean commented Oct 24, 2022

all good?

lua/gruvbox-baby/colors.lua Outdated Show resolved Hide resolved
@luisiacc luisiacc merged commit 19558b9 into luisiacc:main Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants