Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extras: reorganized, added Widows Terminal, added tmux #44

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

crzdg
Copy link
Contributor

@crzdg crzdg commented Nov 4, 2022

Added some extras I use myself,

  • simple file mapping HEX colors with the color name for use in tmux, bash, or similar.
  • Scripts to create mappings for Windows Terminal and add them to the Windows Terminal settings.json.

@crzdg
Copy link
Contributor Author

crzdg commented Nov 12, 2022

@luisiacc Do you plan to merge this at some point?

Let me know if I should change something.

@luisiacc
Copy link
Owner

Hi @crzdg yes I do, sry for the very late reply, this everything looks good, if you can on another PR make a script that will run all of the other scripts for the extras folder, at this point if you want you can also make a Makefile to run that script, so in a way that if I run make extras on cmd, it will regenerate all of the extras files with the latest colors.

@luisiacc luisiacc merged commit f62b3cf into luisiacc:main Nov 14, 2022
@crzdg
Copy link
Contributor Author

crzdg commented Nov 14, 2022

@luisiacc This sound like a great idea!
I will try to remember it as soon I will contribute something new.

We probably also have to think of a way to add the colors of the actual Lua-files to the python dict so we don't have to update it manually. Then we have a pretty neat solution to maintain all those extras.

@luisiacc
Copy link
Owner

you can make a lua script to export the colors to a json file, and use the json file as a source of truth for the external scripts that are not in lua, but then on the sequence of scripts you'll have to always run the lua script first to make sure the colors are up-to-date, this is just the idea that is on the top of my mind right now, if you come up with a better one feel free to pursue it.

@crzdg crzdg deleted the new-extras branch January 18, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants