Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dockerize #20

Merged
merged 2 commits into from
Sep 6, 2016
Merged

dockerize #20

merged 2 commits into from
Sep 6, 2016

Conversation

thomasdziedzic
Copy link
Contributor

No description provided.

@thomasdziedzic thomasdziedzic force-pushed the dockerize branch 2 times, most recently from fb64cd8 to 276b5c4 Compare August 4, 2016 22:57
@steverice
Copy link
Collaborator

Great!
Can we parameterize the ruby and pt-osc versions that will be used for the machine? That will allow testing any combination like we do with the Travis matrix.
If not, I'd prefer that we use the latest supported Ruby version as the default test environment.

@thomasdziedzic
Copy link
Contributor Author

I'm not aware of any way to parameterize the FROM command.

According to https://docs.docker.com/engine/reference/builder/#/environment-replacement
it supports a handful of commands, but FROM isn't one of them.

Updated the Dockerfile to point to 2.2.

@steverice steverice merged commit 639e14f into luismottacampos:master Sep 6, 2016
@thomasdziedzic thomasdziedzic deleted the dockerize branch September 30, 2016 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thomasdziedzic @steverice @thomasdziedzic-pd