Warn when ALTERing without PtOscMigration #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steverice
force-pushed
the
migration-warning
branch
3 times, most recently
from
d400f5f
to
875df0d
Compare
This will allow them to be used in other tests.
steverice
force-pushed
the
migration-warning
branch
from
875df0d
to
1d4e2cd
Compare
If an ALTER command is being called on the MysqlPtOscAdapter without coming from a PtOscMigration, this usually means that commands will be queued up in the commands hash and never actually executed. This results in silent failure. To make this failure more apparent, issue a warning when add_command is called and PtOscMigration does not appear in the stack trace.
Some names — primarily "id" — have special meaning to Rails. To be safe, just choose predefined strings instead of using Faker.
Prior to 4.1.0, when Railties loaded rake tasks it would set verbosity to nil: TylerRick/rails@9affba8 Since we want the warning about not using PtOscMigration to be displayed, explicitly enable warnings for older versions of Rails.
Update CHANGELOG
steverice
force-pushed
the
migration-warning
branch
from
5e36bba
to
6b41d07
Compare
steverice
added a commit
that referenced
this pull request
Mar 9, 2015
Warn when ALTERing without PtOscMigration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an
ALTERcommand is being called on theMysqlPtOscAdapterwithout coming from aPtOscMigration, this usually means that commands will be queued up in the commands hash and never actually executed. This results in silent failure.To make this failure more apparent, issue a warning when
add_commandis called andPtOscMigrationdoes not appear in the stack trace.