Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Hook for NSURLSession #60

Merged
merged 6 commits into from
Jan 18, 2014
Merged

[WIP] Hook for NSURLSession #60

merged 6 commits into from
Jan 18, 2014

Conversation

luisobo
Copy link
Owner

@luisobo luisobo commented Jan 9, 2014

  • figure out why swizzle -[NSURLSessionConfiguration protocolClasses] does not work.

@swizzlr
Copy link
Contributor

swizzlr commented Jan 15, 2014

I just bumped into this problem. What is it precisely that needs to be done to support NSURLSession?

@luisobo
Copy link
Owner Author

luisobo commented Jan 15, 2014

The remaining thing is to properly swizzle out -[NSURLSessionConfiguration
protocolClasses] to always return [LSHTTPURLProtocol class] but is not
working :(

El miércoles, 15 de enero de 2014, swizzlr escribió:

I just bumped into this problem. What is it precisely that needs to be
done to support NSURLSession?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/60#issuecomment-32389122
.

@swizzlr
Ensure hook swizzles concrete subclass of NSURLSessionConfiguration.
fc18ef1 
This commit swizzles the actual instance of NSURLSessionConfiguration, which is
__NSCFURLSessionConfiguration. Tests now pass.

Signed-off-by: Luis Solano Bonet <luis@pixable.com>
@swizzlr
Copy link
Contributor

swizzlr commented Jan 17, 2014

ticks box, adds to podfile

@luisobo
Copy link
Owner Author

luisobo commented Jan 17, 2014

@swizzlr what do you want to add to the Podfile?

@luisobo
Copy link
Owner Author

luisobo commented Jan 17, 2014

I'll finish this tonight btw

@swizzlr
Copy link
Contributor

swizzlr commented Jan 17, 2014

Oh nothing, I just made my podfile point to this commit instead.

@swizzlr
Copy link
Contributor

swizzlr commented Jan 17, 2014

Totally warrants a patch release though.

@luisobo
Copy link
Owner Author

luisobo commented Jan 17, 2014

Yeah def. I'll take care of it tonight.

El viernes, 17 de enero de 2014, swizzlr notifications@github.com
escribió:

Totally warrants a patch release though.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/60#issuecomment-32639078
.

luisobo added a commit that referenced this pull request Jan 18, 2014
@luisobo
Merge pull request #60 from luisobo/nsurlsession-hook
a8fff06 
[WIP] Hook for NSURLSession
@luisobo luisobo merged commit a8fff06 into master Jan 18, 2014
@luisobo luisobo deleted the nsurlsession-hook branch January 18, 2014 03:28
@luisobo luisobo mentioned this pull request Jan 18, 2014
Closed
@kreeger kreeger mentioned this pull request Jan 29, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@luisobo @swizzlr