Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update setup.py + __version__ not defined #118

Closed
wants to merge 1 commit into from
Closed

Update setup.py + __version__ not defined #118

wants to merge 1 commit into from

Conversation

jasmcaus
Copy link

@jasmcaus jasmcaus commented Oct 4, 2020

Fixed whitespace issues. Conformed file to PEP8. __version__ variable not defined - illegal usage.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.405% when pulling 71a049d on jasmcaus:master into 382fb2a on luispedro:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.405% when pulling 71a049d on jasmcaus:master into 382fb2a on luispedro:master.

@luispedro
Copy link
Owner

Whitespace changes mess up git's history (which I do care about) and the __version__ change is actually incorrect.

@luispedro luispedro closed this Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jasmcaus @coveralls @luispedro