Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

The default value of flex-basis is 0% #22

Merged
merged 1 commit into from
Sep 12, 2015
Merged

The default value of flex-basis is 0% #22

merged 1 commit into from
Sep 12, 2015

Conversation

silvenon
Copy link
Contributor

Sorry for giving you the wrong info in #21 馃槄 The initial value is auto, I got them mixed up. Let me make it up to you by submitting a PR.

These are tests for now, code will come soon.

@silvenon silvenon mentioned this pull request Sep 12, 2015
@silvenon
Copy link
Contributor Author

Ready.

But contains changes from #24, so that one should be pulled first. (Should've made it a one PR instead of two, my bad.)

@silvenon silvenon changed the title [WIP] The default value of flex-basis is 0% The default value of flex-basis is 0% Sep 12, 2015
@luisrudge
Copy link
Owner

ok, I merged #24. can you fix the conflicts? Thanks so much for your help!

The INITIAL value is `auto`, silly me.
@silvenon
Copy link
Contributor Author

Fixed.

No problem, thanks for making the plugin 馃憤 (You could maybe submit a PR to the flexbugs repo linking to this plugin.)

luisrudge added a commit that referenced this pull request Sep 12, 2015
The default value of flex-basis is 0%
@luisrudge luisrudge merged commit 89ebf48 into luisrudge:master Sep 12, 2015
@luisrudge
Copy link
Owner

@silvenon
Copy link
Contributor Author

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants