Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, by trying to port the plugin to use the more efficient PostCSS 8 API, I’ve noticed there’s some confusing logic inside the plugin that prevents this. In the end, as it is, this pull request does not add much except maybe future proofing, but I thought I’d share it to save you some time if you ever try porting yourself.
If I replace the
walkDecls()
call withDeclaration()
, the plugin goes into an infinite loop when I run the tests. The PostCSS migration guide saysI believe
bug4()
sees the same node again afterbug6()
processes it and adds the0%
flex basis value thatbug6()
then removes again and so on. Because I am not sure I understand the intention adding then removing the0%
, I went back to walking the tree with theRoot
listener.