Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: defaults host to localhost and port to 5000 #3

Merged
merged 2 commits into from
Jan 26, 2023
Merged

refactor: defaults host to localhost and port to 5000 #3

merged 2 commits into from
Jan 26, 2023

Conversation

fadiinho
Copy link
Contributor

Closes #2

luisviniciuslv
luisviniciuslv requested changes Jan 25, 2023
View reviewed changes
Copy link
Owner

@luisviniciuslv luisviniciuslv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

É preciso fazer a verificação de caso o ip seja "0.0.0.0" pegue o ip padrão do sistema! Atualmente ele verifica se é None para fazer isso.

@luisviniciuslv luisviniciuslv merged commit 31cbebb into luisviniciuslv:main Jan 26, 2023
@fadiinho fadiinho deleted the refactor/default-host-and-port branch January 26, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bielgomes Bielgomes Bielgomes approved these changes

@luisviniciuslv luisviniciuslv Awaiting requested review from luisviniciuslv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ENHACEMENT] Default host to localhost and port to 5000
3 participants
@fadiinho @Bielgomes @luisviniciuslv