Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: auto scroll down message list #11

Closed
warpdesign opened this issue Jan 9, 2018 · 4 comments · Fixed by #12
Closed

Suggestion: auto scroll down message list #11

warpdesign opened this issue Jan 9, 2018 · 4 comments · Fixed by #12

Comments

@warpdesign
Copy link

warpdesign commented Jan 9, 2018

When a new message is received, the message list doesn't autoscroll to the bottom of the list, making the new message invisible if there is a scrollbar in <mat-list/>.

Suggestion: auto-scroll the message list to the bottom when a new message is received.

I had a quick look at the source code but am not sure how to do that in a clean angular-2 way.

@ultrarunner
Copy link
Contributor

ultrarunner commented Jan 11, 2018

I think I have a fix for this issue but I am not sure how to push it back up so that it can be merged. This would be my first attempt to fix an open issue on github. Can someone point me in the right direction? Do I have to be added as a contributor to be able to push my local branch/fix up? Should I fork it? Thank you. Sorry.

@ultrarunner
Copy link
Contributor

I figured out how to create a pull request by forking the code. Please let me know if you have any questions. Thank you.

@luixaviles
Copy link
Owner

Hi @ultrarunner. Take a look into first-contributions repository. You'll find the steps for your first contribution on Github.

@luixaviles
Copy link
Owner

Pull Request #12 solved this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants