Adicionar doc sobre logging #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanmask
reviewed
Oct 15, 2021
| from api_pedidos.config_logging import logging | ||
|
|
||
|
|
||
| LOGGER = logging.getLogger(__name__) |
There was a problem hiding this comment.
``
Suggested change
| LOGGER = logging.getLogger(__name__) | |
| logger = logging.getLogger(__name__) |
uppercase é utilizado para constantes de acordo com a PEP8
There was a problem hiding this comment.
Oi @jeanmask mas a idéia do logger é ser uma global
There was a problem hiding this comment.
Uma variavel global continua sendo uma variavel, então é minúsculo, hehe
There was a problem hiding this comment.
Incisive vc pode observar isso nos exemplos da lib logging da doc do python
jeanmask
reviewed
Oct 15, 2021
|
|
||
| @app.get("/healthcheck") | ||
| async def healthcheck(): | ||
| LOGGER.debug("Hello healthcheck!") |
There was a problem hiding this comment.
Suggested change
| LOGGER.debug("Hello healthcheck!") | |
| logger.debug("Hello healthcheck!") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
O PR tem como objetivo adicionar uma sugestão de documentação para utilização de logging.
Detalhe: Não fiz os links de voltar e avançar, pois não sei em que parte vai se encaixar.