Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(analytic): fix a typo in umami #788

Merged
merged 1 commit into from Mar 22, 2023
Merged

feat(analytic): fix a typo in umami #788

merged 1 commit into from Mar 22, 2023

Conversation

eastonman
Copy link
Contributor

Prerequisites

  • This pull request fixes a bug.
  • This pull request adds a feature.
  • This pull request introduces breaking change.

Description

This PR fix a typo in the added Umami analytic introduced in #787.
The typo resulted in siteID not properly read from config and therefore does not work with umami.

Issues Resolved

N/A

Checklist

General

  • Describe what changes are being made
  • Explain why and how the changes were necessary and implemented respectively
  • Reference issue with #<ISSUE_NO> if applicable

Resources

  • If you have changed any SCSS code, run make release to regenerate all CSS files

Contributors

  • Add yourself to CONTRIBUTORS.md if you aren't on it already

luizdepra
luizdepra approved these changes Mar 22, 2023
View reviewed changes
Copy link
Owner

@luizdepra luizdepra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right! Ty.

@luizdepra luizdepra merged commit a198b8e into luizdepra:main Mar 22, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luizdepra luizdepra luizdepra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eastonman @luizdepra