Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shfmt does not fail anymore #44

Closed
haraldh opened this issue May 4, 2021 · 1 comment · Fixed by #45
Closed

shfmt does not fail anymore #44

haraldh opened this issue May 4, 2021 · 1 comment · Fixed by #45

Comments

@haraldh
Copy link

haraldh commented May 4, 2021

The -d option got lost in #40

action-sh-checker/entrypoint.sh

Line 158 in 1be1f45

shfmt_output="$(shfmt "${args[@]}" "${sh_files[@]}" 2>&1)"

CC: @rasa
@haraldh haraldh mentioned this issue May 4, 2021
Merged
haraldh added a commit to haraldh/dracut that referenced this issue May 4, 2021
@haraldh
style: make indent and let shfmt fail again
a595da7 
The bump of removed the `-d` option for `shfmt`. Readd it until upstream
is fixed.

See also:
luizm/action-sh-checker#44
haraldh added a commit to dracutdevs/dracut that referenced this issue May 4, 2021
@haraldh
style: make indent and let shfmt fail again
373eada 
The bump of removed the `-d` option for `shfmt`. Readd it until upstream
is fixed.

See also:
luizm/action-sh-checker#44
@rasa rasa mentioned this issue May 4, 2021
Merged
rasa added a commit to rasa/action-sh-checker that referenced this issue May 4, 2021
@rasa
fix: Add -d option back to shfmt command
34f88bf 
Fixes luizm#44
@rasa rasa mentioned this issue May 4, 2021
Merged
@luizm luizm closed this as completed in #45 May 4, 2021
@luizm
Copy link
Owner

luizm commented May 4, 2021

https://github.com/luizm/action-sh-checker/releases/tag/v0.2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Add -d option back to shfmt command rasa/action-sh-checker
2 participants
@haraldh @luizm