Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure internal macros end with _ #2

Closed
GoogleCodeExporter opened this issue Aug 1, 2015 · 3 comments
Closed

Make sure internal macros end with _ #2

GoogleCodeExporter opened this issue Aug 1, 2015 · 3 comments

Comments

@GoogleCodeExporter
Copy link

Macros don't respect namespaces, so it is sometimes hard for a user to tell
whether a Google Test macro is public or not.

To reduce the likelihood of a user accidentally depend on Google Test's
internal implementation, we should name all internal macros *_ (i.e. ending
with an underscore).

Original issue reported on code.google.com by shiq...@gmail.com on 2 Jul 2008 at 7:26

@GoogleCodeExporter
Copy link
Author

Original comment by markus.h...@gmail.com on 30 Sep 2008 at 10:57

@GoogleCodeExporter
Copy link
Author

Markus did this in trunk.  I need to scan the code to see if there are any more 
macros that should be converted.

Original comment by shiq...@gmail.com on 12 Oct 2008 at 3:23

@GoogleCodeExporter
Copy link
Author

There are some macros still needing the fix.  I've done it in a pending CL 
which has 
been reviewed by Vlad and will be checked in on Monday.

Original comment by zhanyong...@gmail.com on 22 Feb 2009 at 5:45

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant