Update rubocop: 1.47.0 → 1.51.0 (minor) #64

depfu · 2023-05-14T09:19:31Z

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (1.47.0 → 1.51.0) · Repo · Changelog

Release Notes

1.51.0

New features

#11819: Add autocorrection for Lint/AmbiguousBlockAssociation. (@r7kamura)

#11597: Add autocorrection for Lint/UselessAssignment. (@r7kamura)

#11848: Add autocorrection for Lint/Void. (@r7kamura)

#11851: Add autocorrection for Naming/MemoizedInstanceVariableName. (@r7kamura)

#11856: Add autocorrection for Style/CombinableLoops. (@r7kamura)

#11824: Add autocorrection for Lint/TopLevelReturnWithArgument. (@r7kamura)

#11869: Add new Style/ExactRegexpMatch cop. (@koic)

#11814: Make Style/CollectionCompact aware of delete_if. (@koic)

#11866: Make Style/Semicolon aware of redundant semicolons in string interpolation braces. (@koic)

Bug fixes

#11812: Fix a false negative for Style/Attr when using attr and method definitions. (@koic)

#11861: Fix a false positive for Layout/SpaceAfterSemicolon when no space between a semicolon and a closing brace of string interpolation. (@koic)

#11830: Fix a false positive for Lint/IncompatibleIoSelectWithFiberScheduler. (@koic)

#11846: Fix a false positive for Lint/RedundantStringCoercion when using to_s(argument) in puts argument. (@koic)

#11865: Fix an error for Naming/ConstantName when assigning a constant from an empty branch of else. (@koic)

#11844: Fix a false positive for Style/RedundantLineContinuation when using line concatenation for assigning a return value and without argument parentheses. (@koic)

#11808: Fix a false positive for Style/RegexpLiteral when using a regexp starts with equal as a method argument. (@koic)

#11822: Fix an error for Layout/SpaceInsideBlockBraces when a method call with a multiline block is used as an argument. (@koic)

#11849: Fix an error for Style/ConditionalAssignment when EnforcedStyle: assign_inside_condition and using empty case condition. (@koic)

#11967: Fix error for Style/IfInsideElse when a deep nested multiline if...then...elsif...else...end. (@koic)

#11842: Fix an error for Style/IfUnlessModifier when using multiple if modifier in the long one line. (@koic)

#11835: Fix an error for Style/RequireOrder when multiple require are not sorted. (@koic)

#11809: Fix an incorrect autocorrect for Naming/RescuedExceptionsVariableName when exception variable is referenced after rescue statement. (@koic)

#11852: Fix an incorrect autocorrect for Style/EvalWithLocation when using eval without line number and with parenthesized method call. (@koic)

#11862: Fix an incorrect autocorrect for Style/GuardClause when using raise in else branch in a one-liner with then. (@koic)

#11868: Fix a false positive for Style/HashExcept when method's receiver/argument is not the same as block key argument. (@fatkodima)

#11858: Fix false positives when using source comments in blocks. (@reitermarkus)

#11510: Fix Lint/UselessAssignment false positive when using numbered block parameters. (@sambostock)

#11872: Fix Gemspec/DevelopmentDependencies not trigger when add_development_dependency has more then one arguments. (@Bhacaz)

#11820: Fix Lint/EmptyConditionalBody false-positives for commented empty elsif body. (@r7kamura)

Changes

#11859: Add rubocop-factory_bot to suggested extensions. (@ydah)

#10791: (Breaking) Drop runtime support for Ruby 2.6 and JRuby 9.3 (CRuby 2.6 compatible). (@koic)

#11826: Exclude **/*.jb from Lint/TopLevelReturnWithArgument. (@r7kamura)

#11871: Mark Style/DataInheritance as unsafe autocorrect, Style/OpenStructUse as unsafe, and Security/CompoundHash as unsafe. (@koic)

1.50.2

Bug fixes

#11799: Fix a false positive for Style/CollectionCompact when using reject on hash to reject nils in Ruby 2.3 analysis. (@koic)

#11792: Fix an error for Lint/DuplicateMatchPattern when using hash pattern with if guard. (@koic)

#11800: Mark Style/InvertibleUnlessCondition as unsafe. (@koic)

1.50.1

Bug fixes

#11787: Fix a false positive for Lint/DuplicateMatchPattern when repeated in patterns but different if guard is used. (@koic)

#11789: Fix false negatives for Style/ParallelAssignment when Ruby 2.7+. (@koic)

#11783: Fix a false positive for Style/RedundantLineContinuation using line concatenation for assigning a return value and without argument parentheses. (@koic)

1.50.0

New features

#11749: Add new Lint/DuplicateMatchPattern cop. (@koic)

#11773: Make Layout/ClassStructure aware of singleton class. (@koic)

#11779: Make Lint/RedundantStringCoercion aware of print method arguments. (@koic)

#11776: Make Metrics/ClassLength aware of singleton class. (@koic)

#11775: Make Style/TrailingBodyOnClass aware of singleton class. (@koic)

Bug fixes

#11758: Fix a false positive for Style/RedundantLineContinuation when line continuations for string. (@koic)

#11754: Fix a false positive for Style/RedundantLineContinuation when using && and || with a multiline condition. (@ydah)

#11765: Fix an error for Style/MultilineMethodSignature when line break after def keyword. (@koic)

#11762: Fix an incorrect autocorrect for Style/ClassEqualityComparison when comparing a variable or return value for equality. (@koic)

#11752: Fix a false positive for Style/RedundantLineContinuation when using line concatenation and calling a method without parentheses. (@koic)

1.49.0

New features

#11122: Add new Style/RedundantLineContinuation cop. (@ydah)

#11696: Add new Style/DataInheritance cop. (@ktopolski)

#11746: Make Layout/EndAlignment aware of pattern matching. (@koic)

#11750: Make Metrics/BlockNesting aware of numbered parameter. (@koic)

#11699: Make Style/ClassEqualityComparison aware of Class#to_s and Class#inspect for class equality comparison. (@koic)

#11737: Make Style/MapToHash and Style/MapToSet aware of numbered parameters. (@koic)

#11732: Make Style/MapToHash and Style/MapToSet aware of symbol proc. (@koic)

#11703: Make Naming/InclusiveLanguage support autocorrection when there is only one suggestion. (@koic)

Bug fixes

#11730: Fix an error for Layout/HashAlignment when using anonymous keyword rest arguments. (@koic)

#11704: Fix a false positive for Lint/UselessMethodDefinition when method definition with non access modifier containing only super call. (@koic)

#11723: Fix a false positive for Style/IfUnlessModifier when using one-line pattern matching as a if condition. (@koic)

#11725: Fix an error when insufficient permissions to server cache dir are granted. (@koic)

#11715: Ensure default configuration loads. (@koic)

#11742: Fix error handling in bundler standalone mode. (@composerinteralia)

#11712: Fix a crash in Lint/EmptyConditionalBody. (@gsamokovarov)

#11641: Fix a false negative for Layout/ExtraSpacing when there are many comments with extra spaces. (@nobuyo)

#11740: Fix a false positive for Lint/NestedMethodDefinition when nested definition inside *_eval and *_exec method call with a numblock. (@ydah)

#11685: Fix incorrect directive comment insertion when percent array violates Layout/LineLength cop. (@nobuyo)

#11706: Fix infinite loop when --disable-uncorrectable option and there is a multi-line percent array violates Layout/LineLength. (@nobuyo)

#11697: Fix Lint/Syntax behavior when --only is not given the cop name. (@koic)

#11709: Fix value omission false positive in Style/MethodCallWithArgsParentheses. (@gsamokovarov)

Changes

#11739: Make Style/RedundantParentheses aware of redundant method argument parentheses. (@koic)

#10766: Use the path given by --cache-root to be the parent for rubocop_cache dir like other ways to specify it. (@nobuyo)

1.48.1

Bug fixes

#11673: Fix incorrect Style/HashSyntax autocorrection for assignment methods. (@gsamokovarov)

#11682: Fix a false positive for Lint/UselessRescue when using Thread#raise in rescue clause. (@koic)

#11672: Fix an error for Layout/BlockEndNewline when multiline block } is not on its own line and it is used as multiple arguments. (@koic)

#11675: Style/AccessorGrouping: Fix sibling detection for methods with type sigs. (@issyl0)

#11658: Fix Lint/Debugger should not allow pry. (@ThHareau)

#11686: Fix Lint/Syntax behavior when Enabled: false of Lint department. (@koic)

#11677: Fix the severity for Lint/Syntax. (@koic)

#11691: Fix an error for Gemspec/DependencyVersion when method called on gem name argument for add_dependency. (@koic)

1.48.0

New features

#11628: Add new Style/DirEmpty cop. (@ydah)

#11629: Add new Style/FileEmpty cop. (@ydah)

Bug fixes

#11654: Fix a false positive for Lint/MissingSuper when no super call and when defining some method. (@koic)

#11661: Fix an error for Style/Documentation when namespace is a variable. (@koic)

#11647: Fix an error for Style/IfWithBooleanLiteralBranches when using () as a condition. (@koic)

#11646: Fix an error for Style/NegatedIfElseCondition when using () as a condition. (@koic)

#11659: Fix an incorrect autocorrect for Lint/OrAssignmentToConstant when using or-assignment to a constant in method definition. (@koic)

#11663: Fix an incorrect autocorrect for Style/BlockDelimiters when multi-line blocks to { and } with arithmetic operation method chain. (@koic)

#11638: Fix a false positive for Lint/UselessAccessModifier when using same access modifier inside and outside the included block. (@ydah)

#11164: Suppress server mode message with -f json. (@jasondoc3)

#11643: Fix incorrect shorthand autocorrections in calls inside parentheses. (@gsamokovarov)

#11650: Style/AccessorGrouping: Fix detection of Sorbet sig {} blocks. (@issyl0)

#11657: Use cop name to check if cop inside registry is enabled. Previously, it was able to cause large memory usage during linting. (@fatkodima)

Changes

#11482: Avoid comment deletion by Style/IfUnlessModifier when the modifier form expression has long comment. (@nobuyo)

#11649: Support MinBranchesCount config for Style/CaseLikeIf cop. (@fatkodima)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ parallel (indirect, 1.22.1 → 1.23.0) · Repo

Commits

See the full diff on Github. The new version differs by 10 commits:

↗️ parser (indirect, 3.2.1.0 → 3.2.2.1) · Repo · Changelog

Release Notes

3.2.1.1 (from changelog)

API modifications:

bump racc to 1.6.2 (#916) (Ilya Bylich)

backport tests for mixed usage of anonymous kwarg/kwrestarg and forwarded-arguments (#915) (Ilya Bylich)

add tests for kwopt+kwrest arguments and forwarded_kwrestarg. (#913) (Ilya Bylich)

Bugs fixed:

builders/default: allow forwarded_kwrestarg with additional kwargs (#912) (Owen Stephens)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 18 commits:

↗️ regexp_parser (indirect, 2.7.0 → 2.8.0) · Repo · Changelog

Release Notes

2.8.0 (from changelog)

Added

Regexp::Expression::Shared#ends_at

e.g. parse(/a +/x)[0].ends_at # => 3

e.g. parse(/a +/x)[0].ends_at(include_quantifier = false) # => 1

Regexp::Expression::Shared#{capturing?,comment?}

previously only available on capturing and comment groups

Regexp::Expression::Shared#{decorative?}

true for decorations: comment groups as well as comments and whitespace in x-mode

Regexp::Expression::Shared#parent

new format argument :original for Regexp::Expression::Base#to_s

includes decorative elements between node and its quantifier

e.g. parse(/a (?#comment) +/x)[0].to_s(:original) # => "a (?#comment) +"

using it is not needed when calling Root#to_s as Root can't be quantified

support calling Subexpression#{each_expression,flat_map} with a one-argument block

in this case, only the expressions are passed to the block, no indices

support calling test methods at Expression class level

capturing?, comment?, decorative?, referential?, terminal?

e.g. Regexp::Expression::CharacterSet.terminal? # => false

Fixed

Regexp::Expression::Shared#full_length with whitespace before quantifier

e.g. parse(/a +/x)[0].full_length used to yield 2, now it yields 3

Subexpression#to_s output with children with whitespace before their quantifier

e.g. parse(/a + /x).to_s used to yield "a+ ", now it yields "a + "

calling #to_s on sub-nodes still omits such decorative interludes by default

use new #to_s format :original to include it

e.g. parse(/a + /x)[0].to_s(:original) # => "a +"

fixed Subexpression#te behaving differently from other expressions

only Subexpression#te used to include the quantifier

now #te is the end index without quantifier, as for other expressions

fixed NoMethodError when calling #starts_at or #ts on empty sequences

e.g. Regexp::Parser.parse(/|/)[0].starts_at

e.g. Regexp::Parser.parse(/[&&]/)[0][0].starts_at

fixed nested comment groups breaking local x-options

e.g. in /(?x:(?#hello)) /, the x-option wrongly applied to the whitespace

fixed nested comment groups breaking conditionals

e.g. in /(a)(?(1)b|c(?#hello)d)e/, the 2nd conditional branch included "e"

fixed quantifiers after comment groups being mis-assigned to that group

e.g. in /a(?#foo){3}/ (matches 'aaa')

fixed Scanner accepting two cases of invalid Regexp syntax

unmatched closing parentheses ()) and k-backrefs with number 0 (\k<0>)

these are a SyntaxError in Ruby, so could only be passed as a String

they now raise a Regexp::Scanner::ScannerError

fixed some scanner errors not inheriting from Regexp::Scanner::ScannerError

reduced verbosity of inspect / pretty print output

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 37 commits:

↗️ rubocop-ast (indirect, 1.27.0 → 1.28.1) · Repo · Changelog

Release Notes

1.28.1 (from changelog)

Bug fixes

#262: Fix an error when parsing non UTF-8 frozen string. (@koic)

1.28.0 (from changelog)

New features

#259: Add forwarded_kwrestarg node to AST::Builder. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 11 commits:

↗️ ruby-progressbar (indirect, 1.12.0 → 1.13.0) · Repo · Changelog

Release Notes

1.13.0 (from changelog)

Add

Ability To Allow Different Projectors To Be Used For Time Estimates

Concept Of A Projector

Ability To Access Progress Bar Instance Using Enumerator Refinement

Remove

smoothing Option

Change

Issue Caused By Ruby Bug

Does any of this look wrong? Please let us know.

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands

@depfu rebase
Rebases against your default branch and redoes this update

@depfu recreate
Recreates this PR, overwriting any edits that you've made to it

@depfu merge
Merges this PR once your tests are passing and conflicts are resolved

@depfu cancel merge
Cancels automatic merging of this PR

@depfu close
Closes this PR and deletes the branch

@depfu reopen
Restores the branch and reopens this PR (if it's closed)

@depfu pause
Ignores all future updates for this dependency and closes this PR

@depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR

@depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

depfu · 2023-06-03T10:50:57Z

Closed in favor of #69.

Update rubocop to version 1.51.0

f36e3f5

depfu bot added the depfu label May 14, 2023

depfu bot mentioned this pull request May 14, 2023

Update rubocop: 1.47.0 → 1.50.2 (minor) #56

Closed

depfu bot closed this Jun 3, 2023

depfu bot deleted the depfu/update/rubocop-1.51.0 branch June 3, 2023 10:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update rubocop: 1.47.0 → 1.51.0 (minor) #64

Update rubocop: 1.47.0 → 1.51.0 (minor) #64

depfu bot commented May 14, 2023

depfu bot commented Jun 3, 2023

Update rubocop: 1.47.0 → 1.51.0 (minor) #64

Update rubocop: 1.47.0 → 1.51.0 (minor) #64

Conversation

depfu bot commented May 14, 2023

What changed?

✳️ rubocop (1.47.0 → 1.51.0) · Repo · Changelog

1.51.0

New features

Bug fixes

Changes

1.50.2

Bug fixes

1.50.1

Bug fixes

1.50.0

New features

Bug fixes

1.49.0

New features

Bug fixes

Changes

1.48.1

Bug fixes

1.48.0

New features

Bug fixes

Changes

↗️ parallel (indirect, 1.22.1 → 1.23.0) · Repo

↗️ parser (indirect, 3.2.1.0 → 3.2.2.1) · Repo · Changelog

3.2.1.1 (from changelog)

↗️ regexp_parser (indirect, 2.7.0 → 2.8.0) · Repo · Changelog

2.8.0 (from changelog)

Added

Fixed

↗️ rubocop-ast (indirect, 1.27.0 → 1.28.1) · Repo · Changelog

1.28.1 (from changelog)

Bug fixes

1.28.0 (from changelog)

New features

↗️ ruby-progressbar (indirect, 1.12.0 → 1.13.0) · Repo · Changelog

1.13.0 (from changelog)

Add

Remove

Change

depfu bot commented Jun 3, 2023