Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

json-unit-assertj does not resolve in an OSGi environment #321

Closed
rotty3000 opened this issue Jan 30, 2021 · 0 comments
Closed

json-unit-assertj does not resolve in an OSGi environment #321

rotty3000 opened this issue Jan 30, 2021 · 0 comments

Comments

@rotty3000
Copy link
Contributor

I expected the json-unit-assertj (and dependencies) to work in an OSGi environment because they are OSGi bundles. However it seems the OSGi metadata is slightly incorrect, as well as having a dependency on (un-exported) internals of AssertJ.

I intend to send a PR that corrects the issue, and also includes a build plugin verifying this remains the case.
rotty3000 added a commit to rotty3000/JsonUnit that referenced this issue Jan 30, 2021
@rotty3000
[lukas-krecan#321] don't import the kotlin packages because these are…
031ad4c 
… build artifacts

Signed-off-by: Raymond Augé <raymond.auge@liferay.com>
rotty3000 added a commit to rotty3000/JsonUnit that referenced this issue Jan 30, 2021
@rotty3000
[lukas-krecan#321] stop relying on assertj internals (essential for a…
a6b3542 
…ny hope of working in OSGi)

Signed-off-by: Raymond Augé <raymond.auge@liferay.com>
rotty3000 added a commit to rotty3000/JsonUnit that referenced this issue Jan 30, 2021
@rotty3000
[lukas-krecan#321] add package that was missing to the exports in ord…
c78ba44 
…er for other json-unit-* bundles to work in OSGi

Signed-off-by: Raymond Augé <raymond.auge@liferay.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rotty3000