using Math.ceil() instead of BigDecimal rounding when calculating sec…

…onds
lukas-krecan · Jan 6, 2021 · 6b52104 · 6b52104
1 parent e380b79
commit 6b52104
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/...k-provider-etcd/src/main/java/net/javacrumbs/shedlock/provider/etcd/EtcdLockProvider.java b/...k-provider-etcd/src/main/java/net/javacrumbs/shedlock/provider/etcd/EtcdLockProvider.java
@@ -35,8 +35,6 @@
 import net.javacrumbs.shedlock.support.LockException;
 import net.javacrumbs.shedlock.support.annotation.NonNull;
 
-import java.math.BigDecimal;
-import java.math.RoundingMode;
 import java.time.Duration;
 import java.time.Instant;
 import java.util.Optional;
@@ -72,7 +70,7 @@ public Optional<SimpleLock> lock(@NonNull LockConfiguration lockConfiguration) {
     }
 
     private static final class EtcdLock extends AbstractSimpleLock {
-        private static final BigDecimal MILLIS_IN_SECOND = BigDecimal.valueOf(1000);
+        private static final long MILLIS_IN_SECOND = 1000L;
         private final String key;
         private Long successLeaseId;
         private final EtcdTemplate etcdTemplate;
@@ -121,9 +119,7 @@ public void doUnlock() {
         }
 
         private long getSecondsUntil(Instant instant) {
-            return BigDecimal.valueOf(getMsUntil(instant))
-                .divide(MILLIS_IN_SECOND, RoundingMode.CEILING)
-                .longValue();
+            return (long) Math.ceil((double) getMsUntil(instant) / MILLIS_IN_SECOND);
         }
 
         private long getMsUntil(Instant instant) {