RedisConnectionFactory support

[ghost]

Hello there,

People who use SpringBoot and Redis have some problem with your Redis-provider. SpringBoot gives us some nice and easy configuration with RedisConnectionFactory. This CF uses the same RedisPool inside the implementation but that is private so no way to get it. Instead it gives us RedisConnection.

I created some nice implementation for your LockProvider interface. I can give it back to the community but I need some information about proper contributions here for that.

Thanks in advance.

[lukas-krecan]

Hi, thanks, do not hesitate to send a pull-request, contributions are welcome. (current Redis implementation has been contributed as well)

[clamey]

The current Redis implementation is Jedis specific and not reliant on anything from Spring. You can use Spring to configure it, but the JedisLockProvider implementation code just needs the Jedis jar to work.

Maybe for a Spring-based Redis provider, it should be a new sub-project (shedlock-provider-redis-connection)?

For giving back, I found it easiest to Fork the whole project, make my changes, and then do a Pull Request from my forked project back to lukas-krecan/ShedLock. It can then be reviewed and commented on.

[ghost]

Thank you guys, I will see what can I do. :)

[ghost]

Main file is uploaded already.
Test file and pom is coming soon.

[lukas-krecan]

Cool, let me know if you need any help.

[lukas-krecan]

Hi, just in case you do not have time to work on it, I will be more than happy to finish it.

[ghost]

I was way too busy sorry. Now I can do some work with this.
It might have one bug but I just can't trace it back. Most of the time it works like charm. Maybe it is my redis setup. Locks go wrong like once in a month.

[lukas-krecan]

OK. What sometimes happens is that locked tasks are shorter than the time-shift between machines in the cluster. So the task is executed multiple times (not in parallel but one after each other). Can be prevented by setting lockAtLeastFor. Maybe it's your case, maybe not. In any case, just let me know if you need any help.

[ghost]

lockAtLeastFor is set and most of the time it works. Sometimes redis doesn't expire or delete (? under investigate) the key for the lock, so basically it stucks in the db and causes no more job execution.

[ghost]

I think we can close it now.