New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RedisFactoryLockProvider impl #49
Conversation
Any chance we could get the main REAME updated to include an example of how to set this up? |
Redis (using RedisConnectionFactory)Import <dependency>
<groupId>net.javacrumbs.shedlock</groupId>
<artifactId>shedlock-provider-redis-connectionfactory</artifactId>
<version>0.17.1</version>
</dependency> and configure @Bean
public LockProvider lockProvider(RedisConnectionFactory redisConnectionFactory) {
return new RedisFactoryLockProvider(redisConnectionFactory);
} |
I dunno what's go wrong with my test, when I run in IDE as JUnit it works. Any idea? |
Thanks, I will look at it in next few days. |
Any chance we get this check failed fixed? |
Sorry, I do not understand? |
Why could I not find that code on master? |
It's here https://github.com/lukas-krecan/ShedLock/tree/master/shedlock-provider-redis-spring I have renamed the module. I am still not sure about the name, that's why it's not released yet. |
Ahhh, ok! I just copied the Provider to my code and I will wait for the release. |
Maybe we change the Jedis one to shedlock-provider-redis-jedis to keep these two consistent like the shedlock-provider-jdbc-* ones? |
Yes, but it would require to do something like this #51 in order to keep it backward-compatible But maybe better now then later. (it also changes the package name to keep it consistent) |
Released as 0.18.0 |
You should update the Wiki as well. |
#47 for this issue.
For this implementation you need SpringBoot.
Configuration is pretty same as the Jedis version but it uses RedisConnectionFactory instead of JedisPool.