Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RedisFactoryLockProvider impl #49

Merged
merged 1 commit into from Feb 3, 2018
Merged

RedisFactoryLockProvider impl #49

merged 1 commit into from Feb 3, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jan 31, 2018

#47 for this issue.
For this implementation you need SpringBoot.

Configuration is pretty same as the Jedis version but it uses RedisConnectionFactory instead of JedisPool.

@clamey
Copy link
Contributor

clamey commented Jan 31, 2018

Any chance we could get the main REAME updated to include an example of how to set this up?

@ghost
Copy link
Author

ghost commented Jan 31, 2018

Redis (using RedisConnectionFactory)

Import

<dependency>
    <groupId>net.javacrumbs.shedlock</groupId>
    <artifactId>shedlock-provider-redis-connectionfactory</artifactId>
    <version>0.17.1</version>
</dependency>

and configure

@Bean
public LockProvider lockProvider(RedisConnectionFactory redisConnectionFactory) {
	return new RedisFactoryLockProvider(redisConnectionFactory);
}

@ghost
Copy link
Author

ghost commented Feb 1, 2018

I dunno what's go wrong with my test, when I run in IDE as JUnit it works. Any idea?

@lukas-krecan
Copy link
Owner

Thanks, I will look at it in next few days.

@lukas-krecan lukas-krecan merged commit 8b55fc2 into lukas-krecan:master Feb 3, 2018
@marcioviegas
Copy link

Any chance we get this check failed fixed?

@lukas-krecan
Copy link
Owner

Sorry, I do not understand?

@marcioviegas
Copy link

Why could I not find that code on master?

@lukas-krecan
Copy link
Owner

It's here https://github.com/lukas-krecan/ShedLock/tree/master/shedlock-provider-redis-spring I have renamed the module. I am still not sure about the name, that's why it's not released yet.

@marcioviegas
Copy link

Ahhh, ok! I just copied the Provider to my code and I will wait for the release.
Thanks @lukas-krecan

@clamey
Copy link
Contributor

clamey commented Feb 12, 2018

Maybe we change the Jedis one to shedlock-provider-redis-jedis to keep these two consistent like the shedlock-provider-jdbc-* ones?

@lukas-krecan
Copy link
Owner

lukas-krecan commented Feb 12, 2018

Yes, but it would require to do something like this #51 in order to keep it backward-compatible But maybe better now then later. (it also changes the package name to keep it consistent)

@lukas-krecan
Copy link
Owner

Released as 0.18.0

@ghost
Copy link
Author

ghost commented Feb 13, 2018

You should update the Wiki as well.
Thank you guys for my first contribution. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants