Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VERY rough first draft of context in ibl. #668

Closed
wants to merge 8 commits into from

Conversation

Danielkonge
Copy link
Contributor

This is a very rough first draft of an implementation of some kind of context in addition to scope in ibl. I don't have time to work more on this today, but please note that I am just uploading this to see if you already had any comments about changes you would want. This is not close to ready for a commit yet.

Right now the code is not cleaned up at all, and I will have to change a few things still. But I do have basically the behavior I want (see #649) now.

For this first draft most of context is just all copied from scope and then I made a few minor changes.

@lukas-reineke
Copy link
Owner

You basically just implemented scope = { include = { node_type = { ["*"] = { "*" } } } }.
But like I mentioned here #649 (comment) this has too many edge cases. It's not a good enough solution to build a whole feature on.

Please think about the algorithm first. I don't want you to waste time implementing all the other stuff. Without a good algorithm, I am not going to merge this.

@Danielkonge
Copy link
Contributor Author

I will close this pull request for now and submit one without tree sitter for current indent highlighting. That one works on all my cases I tried, but it is slower.

@Danielkonge Danielkonge closed this Oct 2, 2023
@Danielkonge Danielkonge deleted the master branch October 3, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants