-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fast current_indent
implementation
#703
Fast current_indent
implementation
#703
Conversation
f54dad6 'Added show_end_always option to scope (remove fix)'
Even if you end up not accepting this pull request, I think it is worth considering changing utils similar to what I have done with |
@Danielkonge thanks for your work. I think indentation doesn't work correctly in all cases |
I found a bug where |
@Danielkonge now work correctly! |
By now this commit has actually got a few different features mixed into it. It has It now also adds a Would you prefer that I split these out into multiple smaller pull requests @lukas-reineke? Or is it easier for you to do it all at once in one bigger file (like now)? |
Please make smaller PRs 👍 |
@lukas-reineke I have submitted 3 smaller pull requests now, and I will add another smaller one with only I am not sure how exactly you want to test these features, but if you clarify what kind of tests you want, I can try to write some tests too. [I didn't see any tests for scope to base my tests on.] |
I finished the new smaller and cleaner pull requests now. |
This is the most up to date implementation mentioned in #649, and I don't feel any slowdown compared to the version without
current_indent
.Please let me know if you want me to change something, then I can edit it during the next few days.