LuaLS updates to follow style guide + better hl #748
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
@as
type annotations to follow: https://luals.github.io/wiki/annotations/#asThis also improves highlighting like seen here:
After update:
![Screenshot 2023-10-23 at 00 09 59](https://private-user-images.githubusercontent.com/7075380/277195458-f256bdee-12e2-46e7-b383-c237e9e7f924.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg4MDgxMTIsIm5iZiI6MTcxODgwNzgxMiwicGF0aCI6Ii83MDc1MzgwLzI3NzE5NTQ1OC1mMjU2YmRlZS0xMmUyLTQ2ZTctYjM4My1jMjM3ZTllN2Y5MjQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDYxOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA2MTlUMTQzNjUyWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MTMxZDA1ZTVmZGNjMDQ5NDUzZWQ1NTA2ZWZiY2JhMDhmYmRhYTU3OTk1MGEwZWVhNGRjNDM5ZGJiODI0MjIyZiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.dQYIr-BHDpQyHKF36SmZ3Ap0gJILamAUpIXRMFzhidE)
Before update:
![Screenshot 2023-10-23 at 00 10 09](https://private-user-images.githubusercontent.com/7075380/277195466-da14b2b3-aeb0-4d09-9c3d-a45e2a009141.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg4MDgxMTIsIm5iZiI6MTcxODgwNzgxMiwicGF0aCI6Ii83MDc1MzgwLzI3NzE5NTQ2Ni1kYTE0YjJiMy1hZWIwLTRkMDktOWMzZC1hNDVlMmEwMDkxNDEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDYxOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA2MTlUMTQzNjUyWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9OWNiMzg3YTYzMDAxOTZhMmNjNGVkMjFjMTAzNGI2OWM5YzFhMmMyMTA3MDg3NDZjMTMyODcxMzhiOGUyZTZlNSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.OB2ZV9QKcn-vZqjQDqMPbtLgg4xBNbkpW67yoFRMBSw)
Note: This wrong highlighting can also be seen in multiple screenshots in the current readme.