Provide content options for HTML attribute extractor (fixes #56) #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasgeiter
requested changes
Oct 23, 2022
arm1n
force-pushed
the
feat-attribute-content-options
branch
from
09376bd
to
6533293
Compare
|
Thanks for your feedback and code review. I've added the changes and would ask you to have one more look, thanks Lukas! |
lukasgeiter
requested changes
Oct 24, 2022
arm1n
force-pushed
the
feat-attribute-content-options
branch
from
6533293
to
b4a07de
Compare
|
Reiterated the PR according to your feedback, thanks for taking the time to look into it. |
|
Thanks for merging Lukas, we should document the content options also on the corresponding wiki page. |
|
Of course! I'll update the wiki publish a release soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Lukas,
this PR introduces the possibility to use content options for
HtmlExtractors.elementAttributethe same way as forHtmlExtractors.elementContent. As usages including default values should very likely be the same I had to move some code into utils for reusability. Besides, all attributes being used get the same content options applied, which was added in the primitive element extractor. Tests should cover these scenarios.Looking forward to your feedback, thanks!