Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a screen to list all keyboard shortcuts #110

Closed
5 tasks done
lukashornych opened this issue Jan 22, 2024 · 2 comments
Closed
5 tasks done

Create a screen to list all keyboard shortcuts #110

lukashornych opened this issue Jan 22, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@lukashornych
Copy link
Owner

lukashornych commented Jan 22, 2024

Right now, there is no way to discover possible keyboard shortcuts that can be used.
It would be helpful to list all available shortcuts, even for codemirror.

  • research possible library to display shortcuts
  • create new tab component with all shortcuts to view and maybe search by name and actual shortcut
  • create button in main navigation to access it
  • test all shortcuts on mac
  • fix CodeMirror shortcuts on macOS
@lukashornych lukashornych added the enhancement New feature or request label Jan 22, 2024
@lukashornych lukashornych self-assigned this Jan 22, 2024
lukashornych added a commit that referenced this issue Mar 3, 2024
…ching, keymap viewer, shortcut tooltips...), add keyboard shortcuts into tabs and globally to lab
@lukashornych
Copy link
Owner Author

There is one small caveat to using the keymaster library and it is the global all scope. This scope is used in evitaLab for all of the global shortcuts that should be available anywhere. However, when dialog window is opened, these global shortcuts should be IMO disabled. The issue is that the keymaster library doesn't allow to disable the global context nor it allows to set up multiple active scopes at once (where I could have specific scope for global evitaLab shortcuts).

This issue than allows to e.g. switch tabs while have dialog specific to one tab opened, effectively losing bindings for the dialog window until the original tab is selected again.

The solution could be either extend the keymaster to support multiple action scopes (probably not good idea, lots of software may rely on the switching feature of setting new scopes, including evitaLab), or allowing to enable/disable the global scope.

lukashornych added a commit that referenced this issue Mar 7, 2024
…-all-keyboard-shortcuts

feat(#110): implement keyboard shortcuts system support (context switching, keymap viewer, shortcut tooltips...), add keyboard shortcuts into tabs and globally to lab
@lukashornych
Copy link
Owner Author

Only thing missing is to fix some shortcuts in core CodeMirror editor on macOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant