add similarity test #2
Conversation
Similarity test, about 10% error for Jaccard at about 0.01, consistent with the paper.
|
Thanks for the PR. CI seems legit, please address those |
remove unused declare
|
Should be working this time? Jianshu |
update error calculation
update formula
|
Nope :-) If you run |
|
Hello @lukaslueg , It passed this time on my end. Thanks, Jianshu |
src/lib.rs
Outdated
| let jexact = inter as f64 / vbmax as f64; | ||
| let sketch1: Sketch = va; | ||
| let sketch2: Sketch = vb; | ||
| let _union_size = sketch1.clone().union(&sketch2).cardinality(); |
There was a problem hiding this comment.
If _union_size is unused, the whole line should be removed.
src/lib.rs
Outdated
| } | ||
|
|
There was a problem hiding this comment.
This blank line is causing a rustfmt error
|
Fixed! |
|
The final blank line is still causing a rustfmt error |
|
Sorry for the lack of experience in using clippy and format. I love it after trying so many times (no such tools that can help with formatting to have very high quality code in other languages). I normally just did cargo build and then pass. By the way for the nightly rust v1.80, there are errors there for clippy. It will take some time to have the problem on stable rust, but just to let you know. Jianshu |
Add similarity test, about 10% error for Jaccard at about 0.01, consistent with the paper. Please merge if you find it useful. I would also suggest a comparison with SetSketch, please see the issue I opened.
Thanks,
Jianshu